From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753062AbdLMNir (ORCPT ); Wed, 13 Dec 2017 08:38:47 -0500 Received: from fldsmtpe03.verizon.com ([140.108.26.142]:1819 "EHLO fldsmtpe03.verizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbdLMNio (ORCPT ); Wed, 13 Dec 2017 08:38:44 -0500 From: alexander.levin@verizon.com X-Host: surveyor.tdc.vzwcorp.com To: Johan Hovold CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Marcel Holtmann Subject: Re: [PATCH AUTOSEL for 4.14 19/60] Bluetooth: avoid silent hci_bcm ACPI PM regression Thread-Topic: [PATCH AUTOSEL for 4.14 19/60] Bluetooth: avoid silent hci_bcm ACPI PM regression Thread-Index: AQHTdBeDjpHtehS9wkaeGBitByuHCw== Date: Wed, 13 Dec 2017 13:37:26 +0000 Message-ID: <20171213133716.hfdujad4so652ll2@sasha-lappy> References: <20171213015455.6455-1-alexander.levin@verizon.com> <20171213015455.6455-19-alexander.levin@verizon.com> <20171213081429.GC5185@localhost> In-Reply-To: <20171213081429.GC5185@localhost> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="us-ascii" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBDDcpTW024728 On Wed, Dec 13, 2017 at 09:14:29AM +0100, Johan Hovold wrote: >On Wed, Dec 13, 2017 at 01:55:14AM +0000, alexander.levin@verizon.com wrote: >> From: Johan Hovold >> >> [ Upstream commit 4294625e029028854596865be401b9c5c1f906ef ] >> >> The hci_bcm platform-device hack which was used to implement >> power management for ACPI devices is being replaced by a >> serial-device-bus implementation. >> >> Unfortunately, when the corresponding change to the ACPI code lands (a >> change that will stop enumerating and registering the serial-device-node >> child as a platform device) PM will break silently unless serdev >> TTY-port controller support has been enabled. Specifically, hciattach >> (btattach) would still succeed, but power management would no longer >> work. > >This one is not needed in stable, which does not have the above >mentioned ACPI change [ e361d1f85855 ("ACPI / scan: Fix enumeration for >special UART devices") ]. > >The Fixes and stable-CC tags were left out on purpose. Thanks Johan, I'll remove it. The Fixes tag should probably be there, as on it's own it does not indicate a patch should go into stable, and we have tools to prevent us from applying commits that "Fixes:" something which is not in the tree. -- Thanks, Sasha