From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbdLMPkR (ORCPT ); Wed, 13 Dec 2017 10:40:17 -0500 Received: from mail-ot0-f182.google.com ([74.125.82.182]:38608 "EHLO mail-ot0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753197AbdLMPkL (ORCPT ); Wed, 13 Dec 2017 10:40:11 -0500 X-Google-Smtp-Source: ACJfBouJ62wzWzdhGq2rSq0KnhYhQj2K9NzENSz5dbt5ru9P+FOo3xKM2L8wXc22o8hwjC5YKSnArw== Date: Wed, 13 Dec 2017 09:40:00 -0600 From: Steven Eckhoff To: Mark Brown Cc: alsa-devel@alsa-project.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC Message-ID: <20171213153958.6fgpujl33kzuszur@localhost.localdomain> References: <20171211195403.3irxp7g3n326ub3g@localhost.localdomain> <20171212163254.GL16323@sirena.org.uk> <20171212213114.n5pcgy6q6m3qu5s4@localhost.localdomain> <20171212225134.mmwigvfgi7fbvgyz@localhost.localdomain> <20171213104732.GB6416@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213104732.GB6416@sirena.org.uk> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2017 at 10:47:32AM +0000, Mark Brown wrote: > The things the driver is doing automatically to mute the DACs and ADCs > should be moved to user control if they're not suitable for doing > automatically. > The mutes can work normally without the PLL stuff. I have removed the PLL stuff from the next version and have added a DAPM widget to handle the PLL power up/down. > Please delete unneeded context from mails when replying. Doing this > makes it much easier to find your reply in the message, helping ensure > it won't be missed by people scrolling through the irrelevant quoted > material. I apologize again. I realized that I had done that after it was too late. Thanks for the reviews and all the help. I believe this driver has improved through this process.