From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753481AbdLMPkD (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 10:40:03 -0500
Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35546 "EHLO
        heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753197AbdLMPkB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 10:40:01 -0500
Date: Wed, 13 Dec 2017 15:39:58 +0000
From: Mark Brown <broonie@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH 2/3] regmap: don't create the debugfs entries if locking
 is disabled
Message-ID: <20171213153958.GK6416@sirena.org.uk>
References: <20171213092812.26472-1-brgl@bgdev.pl>
 <20171213092812.26472-3-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Ah40dssYA/cDqAW1"
Content-Disposition: inline
In-Reply-To: <20171213092812.26472-3-brgl@bgdev.pl>
X-Cookie: Causes moderate eye irritation.
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--Ah40dssYA/cDqAW1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 13, 2017 at 10:28:11AM +0100, Bartosz Golaszewski wrote:
> User space can initiate concurrent access to regmap over debugfs and,
> if the locking is disabled, we can't protect it. Don't create the
> debugfs entries at all in this case.

I (probably unsurprisingly) prefer my version that I posted yesterday as
it gives us the trivial memory saving of not having the flag if debugfs
is disabled but more importantly from my point of view keeps the
interface to debugfs as function calls in the core.

--Ah40dssYA/cDqAW1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAloxSc0ACgkQJNaLcl1U
h9AENwf/WTjyX/zculoKUi11vS+IAKnSkLAGoSpRCUShmsfRjOZe/4JLfS31OlX+
HGtD2BtXDbzjsIM4jhrV7zI7BNbVOWJsaGjNPSrdtuFp02Dw+oMVfnYi94GK4pRr
QduidN99NEfVpyDldgNh9Fbwl7sagTYsae+mwAyOObSCZid22s9jC+rWYpolBYJY
lqeEfdlSIsQnPfjo7dY1C58Z5FS+Cq2LjVcm5mU3KU4zFiNZXfq9E0/p0Kt9Mb20
uJVmgBlth22VU4msyW0eeo7bWCTJPo6r8sWQOolU60N9KXUjEbOo5FX5b91yWEkJ
0W+Tgl/6D/3wrw2f5INmbiMhMU1tiQ==
=f02Q
-----END PGP SIGNATURE-----

--Ah40dssYA/cDqAW1--