From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751614AbdLNBDD (ORCPT ); Wed, 13 Dec 2017 20:03:03 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33156 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbdLNBDC (ORCPT ); Wed, 13 Dec 2017 20:03:02 -0500 Date: Wed, 13 Dec 2017 17:03:00 -0800 From: Andrew Morton To: kernel test robot Cc: Christoph Hellwig , LKP , linux-kernel@vger.kernel.org, Linux Memory Management List , wfg@linux.intel.com, Stephen Rothwell Subject: Re: d1fc031747 ("sched/wait: assert the wait_queue_head lock is .."): EIP: __wake_up_common Message-Id: <20171213170300.b0bb26900dd00641819b4872@linux-foundation.org> In-Reply-To: <5a31cac7.i9WLKx5al8+rBn73%fengguang.wu@intel.com> References: <5a31cac7.i9WLKx5al8+rBn73%fengguang.wu@intel.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Dec 2017 08:50:15 +0800 kernel test robot wrote: > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > commit d1fc0317472217762fa7741260ca464077b4c877 > Author: Christoph Hellwig > AuthorDate: Wed Dec 13 11:52:12 2017 +1100 > Commit: Stephen Rothwell > CommitDate: Wed Dec 13 16:04:58 2017 +1100 > > sched/wait: assert the wait_queue_head lock is held in __wake_up_common > > Better ensure we actually hold the lock using lockdep than just commenting > on it. Due to the various exported _locked interfaces it is far too easy > to get the locking wrong. I'm probably sitting on an older version. I've dropped epoll: use the waitqueue lock to protect ep->wq sched/wait: assert the wait_queue_head lock is held in __wake_up_common