From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbdLNFW2 (ORCPT ); Thu, 14 Dec 2017 00:22:28 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33744 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbdLNFW1 (ORCPT ); Thu, 14 Dec 2017 00:22:27 -0500 X-Google-Smtp-Source: ACJfBouv/meGYE8S0DKm74ahT/8bYDZn2SkE7ww8dQhz8FIR338FF1t3L3xmoicB2laTVEWa582wbQ== Date: Thu, 14 Dec 2017 10:52:22 +0530 From: Viresh Kumar To: Greg Kroah-Hartman Cc: Vincent Guittot , Stephen Boyd , Rajendra Nayak , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robdclark@gmail.com, s.hauer@pengutronix.de, l.stach@pengutronix.de, shawnguo@kernel.org, fabio.estevam@nxp.com, nm@ti.com, xuwei5@hisilicon.com, robh+dt@kernel.org Subject: Re: [PATCH V4 09/12] boot_constraint: Add earlycon helper Message-ID: <20171214052222.GW3322@vireshk-i7> References: <20171213094450.GD13194@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213094450.GD13194@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-12-17, 10:44, Greg Kroah-Hartman wrote: > And this feels really odd, does it really save any work for the > individual "constraint" to check for this option? I'm all for helper > functions, but this feels like more work than it's worth... Ok, will move this code to individual platform driver files for now. -- viresh