From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbdLNM5e (ORCPT ); Thu, 14 Dec 2017 07:57:34 -0500 Received: from verein.lst.de ([213.95.11.211]:41634 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbdLNM5c (ORCPT ); Thu, 14 Dec 2017 07:57:32 -0500 Date: Thu, 14 Dec 2017 13:57:31 +0100 From: Christoph Hellwig To: Andrew Morton Cc: kernel test robot , Christoph Hellwig , LKP , linux-kernel@vger.kernel.org, Linux Memory Management List , wfg@linux.intel.com, Stephen Rothwell Subject: Re: d1fc031747 ("sched/wait: assert the wait_queue_head lock is .."): EIP: __wake_up_common Message-ID: <20171214125731.GA10676@lst.de> References: <5a31cac7.i9WLKx5al8+rBn73%fengguang.wu@intel.com> <20171213170300.b0bb26900dd00641819b4872@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213170300.b0bb26900dd00641819b4872@linux-foundation.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2017 at 05:03:00PM -0800, Andrew Morton wrote: > I'm probably sitting on an older version. I've dropped > > epoll: use the waitqueue lock to protect ep->wq > sched/wait: assert the wait_queue_head lock is held in __wake_up_common Thanks. I'll send a v3 over the fixed version with the nits pointed out during review today.