From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358AbdLNPbz (ORCPT ); Thu, 14 Dec 2017 10:31:55 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38554 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753245AbdLNPbx (ORCPT ); Thu, 14 Dec 2017 10:31:53 -0500 Date: Thu, 14 Dec 2017 15:31:39 +0000 From: Mark Brown To: Charles Keepax Cc: "Chen.Liu" , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, shengjiu.wang@freescale.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, daniel.baluta@nxp.com Subject: Re: [PATCH v2] ASOC: wm8960: Add multiple MCLK frequency support Message-ID: <20171214153139.GG9788@sirena.org.uk> References: <1513168650-102028-1-git-send-email-chen.liu.opensource@gmail.com> <20171214115648.qidtgzihdoikxvhe@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cyV/sMl4KAhiehtf" Content-Disposition: inline In-Reply-To: <20171214115648.qidtgzihdoikxvhe@localhost.localdomain> X-Cookie: Every morning is a Smirnoff morning. User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cyV/sMl4KAhiehtf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 14, 2017 at 11:56:48AM +0000, Charles Keepax wrote: > On Wed, Dec 13, 2017 at 08:37:30PM +0800, Chen.Liu wrote: > > + if (unsupported) > > + snd_soc_update_bits(codec, WM8960_CLOCK1, 0x6, > > + WM8960_SYSCLK_DIV_2); > > + > Looking at this a bit more I do have some reservations. Firstly > this divider can be set through wm8960_set_dai_clkdiv, and > secondly it is also set at the bottom of Removing set_clkdiv() would be a better thing if there were conflicts here, in general we're trying to avoid uses of it. --cyV/sMl4KAhiehtf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAloymVoACgkQJNaLcl1U h9Dfywf+JQ2Z2RttyQxXMvQMa1cmrAOBOPv2b2Uv0CH3XcjIjZCxjPaQOsZRQ/Wp XVofEfvmCnMNXzD2Hlp7JWho1r3lIntMal13i2cOYV8Y51/nbeM3+Gu9YWJ10/N2 9gD0WTTNVBKoFHcZfecDibUB415+1L5lDNlk+AOGRUXEhv62HaylzR5XWZEV2oVU ViFv76n0ML+yF3llwQ498YLSlCkA7dNinR3qV93aHRwMCnBqERay7IkUKExVJreM LX9HpDZwp3ub9gNQ97RNOtks+ewzelxXesFfVECSVYRiykdUmd4llEf871laCbFD 1XWMCWZGYCx3h3jGbaWS3SXZr7cBXw== =1mqp -----END PGP SIGNATURE----- --cyV/sMl4KAhiehtf--