From: "Theodore Ts'o" <tytso@mit.edu>
To: Zhouyi Zhou <zhouzhouyi@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
inux-fsdevel@vger.kernel.org
Subject: Re: FS: EXT4: should we sync error info in __ext4_grp_locked_error?
Date: Thu, 14 Dec 2017 11:48:05 -0500 [thread overview]
Message-ID: <20171214164805.lbbsr7nyakhvujes@thunk.org> (raw)
In-Reply-To: <CAABZP2w39PEBue-L1kGk-jh_WQohTtaVJHy-wS_E7QC28FKJSA@mail.gmail.com>
On Thu, Dec 14, 2017 at 03:13:15PM +0800, Zhouyi Zhou wrote:
> Hi,
> In function __ext4_grp_locked_error, __save_error_info(sb, function, line)
> is called to save error info in super block block, but does not sync
> that information
> to disk to info the subsequence fsck after reboot. The reason, I guess
> maybe it is
> in locked state.
> My question is why not make a call ext4_commit_super(sb, 1) after
> ext4_unlock_group(sb, grp) and ext4_handle_error(sb), so that subsequence fsck
> after reboot is sure to be well informed.
Adding ext4_commit_super(sb, 1) between the calls to
ext4_unlock_group() and ext4_handle_error() is a good idea; it's not a
naive suggestion at all.
Cheers,
- Ted
prev parent reply other threads:[~2017-12-14 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 7:13 Zhouyi Zhou
2017-12-14 16:48 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214164805.lbbsr7nyakhvujes@thunk.org \
--to=tytso@mit.edu \
--cc=inux-fsdevel@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®