From: Eric Biggers <ebiggers3@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Dmitry Vyukov <dvyukov@google.com>, Greg KH <greg@kroah.com>,
Kees Cook <keescook@chromium.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
security@kernel.org, Akinobu Mita <akinobu.mita@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
syzkaller-bugs@googlegroups.com,
Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: general protection fault in show_timer
Date: Thu, 14 Dec 2017 10:36:07 -0800 [thread overview]
Message-ID: <20171214183607.GB259981@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1712141631470.4998@nanos>
On Thu, Dec 14, 2017 at 04:34:12PM +0100, Thomas Gleixner wrote:
> On Thu, 14 Dec 2017, Dmitry Vyukov wrote:
> > On Thu, Dec 14, 2017 at 3:26 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > > On Tue, 12 Dec 2017, Greg KH wrote:
> > >> Did this ever go anywhere? I don't see it in Linus's tree yet...
> > >
> > > I learned yesterday that syzboz is understuffed and cannot test patches, so
> > > I need to find a minute to run the reproducer myself and verify that the
> > > patch is correct.
> >
> > Hi Thomas,
> >
> > Why do you say so? Have you tried to ask it to test?
> > https://github.com/google/syzkaller/blob/master/docs/syzbot.md#communication-with-syzbot
> > What happened?
>
> Eric explained that to me yesterday and I did not try yet.
>
Your patch definitely fixes the bug (I tested the C reproducers, you just need
to build a kernel with CONFIG_CHECKPOINT_RESTORE=y and CONFIG_POSIX_TIMERS=y,
then run them). The real question is whether the check being introduced is too
strict -- are there users passing in other values for ->sigev_notify that would
be broken? That I can't really answer.
Eric
next prev parent reply other threads:[~2017-12-14 18:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <94eb2c18a77ce8d832055f2cf263@google.com>
2017-11-30 11:08 ` Alexey Dobriyan
2017-11-30 11:31 ` Dmitry Vyukov
2017-11-30 11:38 ` Dmitry Vyukov
2017-11-30 12:20 ` Alexey Dobriyan
2017-11-30 12:57 ` Dmitry Vyukov
2017-11-30 12:57 ` Thomas Gleixner
2017-12-05 19:58 ` Kees Cook
2017-12-12 8:33 ` Greg KH
2017-12-14 14:26 ` Thomas Gleixner
2017-12-14 14:34 ` Dmitry Vyukov
2017-12-14 15:34 ` Thomas Gleixner
2017-12-14 18:36 ` Eric Biggers [this message]
2017-12-15 16:40 ` Thomas Gleixner
2017-12-19 1:01 ` Eric Biggers
2017-12-04 3:17 ` syzbot
2017-12-04 12:11 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214183607.GB259981@gmail.com \
--to=ebiggers3@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=security@kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome