From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754159AbdLNWgf (ORCPT <rfc822;w@1wt.eu>);
        Thu, 14 Dec 2017 17:36:35 -0500
Received: from mail-oi0-f44.google.com ([209.85.218.44]:34409 "EHLO
        mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753916AbdLNWg3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Dec 2017 17:36:29 -0500
X-Google-Smtp-Source: ACJfBosQuzv5JHvzluUwvxX8CP9SElA6hO2V45HiIqBwf0NFK85qr//uThoym1h6XpGIxxrAq60IAw==
Date: Thu, 14 Dec 2017 16:36:17 -0600
From: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo
 Semiconductor's TSCS42xx audio CODEC
Message-ID: <20171214222955.qicmzltikkwaazly@localhost.localdomain>
References: <20171211195403.3irxp7g3n326ub3g@localhost.localdomain>
 <20171212163254.GL16323@sirena.org.uk>
 <20171212213114.n5pcgy6q6m3qu5s4@localhost.localdomain>
 <20171214093244.udrjwgfvpxpc3jq7@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171214093244.udrjwgfvpxpc3jq7@localhost.localdomain>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 14, 2017 at 09:32:44AM +0000, Charles Keepax wrote:

> Not sure what you mean here but setting up CODEC registers
> directly from the machine driver is probably not ideal. You
> should probably be looking into regmap_register_patch this lets
> you apply a bunch of register settings to the chip every time you
> do a regmap_cache_sync. This is useful for situations like the
> chip has terrible register defaults you want to correct.

Thanks I will keep that in mind. For now our defaults are okay, but
this may come in handy in other drivers. I have removed this bit from
the next version since this can be set by the machine driver and it
makes more sense there since the settings were configuring how the I2S
interfaces were connected.