From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754131AbdLNWnX (ORCPT ); Thu, 14 Dec 2017 17:43:23 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:37814 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753990AbdLNWnU (ORCPT ); Thu, 14 Dec 2017 17:43:20 -0500 X-Google-Smtp-Source: ACJfBosc07Nfo4S3WXoVOYAbFyxw3eLVT8zNHAIybRloa6ZMjwWEkKq1OoejiEuu5qWQ/1nxT0jx2A== Date: Thu, 14 Dec 2017 16:43:10 -0600 From: Steven Eckhoff To: Charles Keepax Cc: Mark Brown , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood Subject: Re: [alsa-devel] [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC Message-ID: <20171214224309.btsuh3ew5lkqfpcf@localhost.localdomain> References: <20171211195403.3irxp7g3n326ub3g@localhost.localdomain> <20171212163254.GL16323@sirena.org.uk> <20171212213114.n5pcgy6q6m3qu5s4@localhost.localdomain> <20171214093244.udrjwgfvpxpc3jq7@localhost.localdomain> <20171214222955.qicmzltikkwaazly@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171214222955.qicmzltikkwaazly@localhost.localdomain> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 14, 2017 at 04:36:17PM -0600, Steven Eckhoff wrote: > On Thu, Dec 14, 2017 at 09:32:44AM +0000, Charles Keepax wrote: > > > Not sure what you mean here but setting up CODEC registers > > directly from the machine driver is probably not ideal. You > > should probably be looking into regmap_register_patch this lets > > you apply a bunch of register settings to the chip every time you > > do a regmap_cache_sync. This is useful for situations like the > > chip has terrible register defaults you want to correct. > > Thanks I will keep that in mind. For now our defaults are okay, but > this may come in handy in other drivers. I have removed this bit from > the next version since this can be set by the machine driver and it > makes more sense there since the settings were configuring how the I2S > interfaces were connected. I apologize I had to reread that. The settings were setting whether the bclk and lrclk would be shared between the DAC and ADC interfaces. I thought this would make sense in the machine driver since it knows how the devices are connected. Is there a better way to do this?