From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756336AbdLOR56 (ORCPT ); Fri, 15 Dec 2017 12:57:58 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:54080 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756279AbdLOR5v (ORCPT ); Fri, 15 Dec 2017 12:57:51 -0500 Date: Fri, 15 Dec 2017 12:57:49 -0500 (EST) Message-Id: <20171215.125749.1752831437819486183.davem@davemloft.net> To: hayashi.kunihiko@socionext.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, yamada.masahiro@socionext.com, masami.hiramatsu@linaro.org, jaswinder.singh@linaro.org Subject: Re: [PATCH net-next v6 2/2] net: ethernet: socionext: add AVE ethernet driver From: David Miller In-Reply-To: <1513245910-15961-3-git-send-email-hayashi.kunihiko@socionext.com> References: <1513245910-15961-1-git-send-email-hayashi.kunihiko@socionext.com> <1513245910-15961-3-git-send-email-hayashi.kunihiko@socionext.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Dec 2017 09:57:51 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kunihiko Hayashi Date: Thu, 14 Dec 2017 19:05:10 +0900 > +static void ave_desc_write(struct net_device *ndev, enum desc_id id, > + int entry, int offset, u32 val) > +{ > + struct ave_private *priv = netdev_priv(ndev); > + u32 addr = (id == AVE_DESCID_TX) ? priv->tx.daddr : priv->rx.daddr; Please always order local variables from longest to shortest line. Audit your entire submission for this issue, thank you. > + ret = register_netdev(ndev); > + if (ret) { > + dev_err(dev, "failed to register netdevice\n"); > + goto out_del_napi; > + } > + > + platform_set_drvdata(pdev, ndev); You must make all software state settings before reigster_netdev() is invoked. At the exact moment you call register_netdev(), your device can be brought up, interrupts processed, PHY state changes made, etc. So you must put this platform_set_drvdata() before the register_netdev() call. Generally speaking, register_netdev() must always be the last state modification done by your probe routine.