From: Alexandre Courbot <acourbot@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pawel Osciak <posciak@chromium.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tfiga@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Gustavo Padovan <gustavo.padovan@collabora.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@chromium.org>
Subject: [RFC PATCH 3/9] media: request: add generic entity ops
Date: Fri, 15 Dec 2017 16:56:19 +0900 [thread overview]
Message-ID: <20171215075625.27028-4-acourbot@chromium.org> (raw)
In-Reply-To: <20171215075625.27028-1-acourbot@chromium.org>
Add skeleton ops for generic entities. The intent is to provide a
generic mechanism to apply request parameters to entities using regular
media/v4l2 functions.
Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
---
drivers/media/Makefile | 3 +-
drivers/media/media-request-entity-generic.c | 56 ++++++++++++++++++++++++++++
include/media/media-request.h | 5 +++
3 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 drivers/media/media-request-entity-generic.c
diff --git a/drivers/media/Makefile b/drivers/media/Makefile
index 90117fff1339..dea482f6ab72 100644
--- a/drivers/media/Makefile
+++ b/drivers/media/Makefile
@@ -4,7 +4,8 @@
#
media-objs := media-device.o media-devnode.o media-entity.o \
- media-request.o media-request-queue-generic.o
+ media-request.o media-request-queue-generic.o \
+ media-request-entity-generic.o
#
# I2C drivers should come before other drivers, otherwise they'll fail
diff --git a/drivers/media/media-request-entity-generic.c b/drivers/media/media-request-entity-generic.c
new file mode 100644
index 000000000000..18e53f9ce525
--- /dev/null
+++ b/drivers/media/media-request-entity-generic.c
@@ -0,0 +1,56 @@
+/*
+ * Media generic entity ops
+ *
+ * Copyright (C) 2017, The Chromium OS Authors. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/slab.h>
+
+#include <media/media-entity.h>
+#include <media/media-request.h>
+
+struct media_request_entity_data_generic {
+ struct media_request_entity_data base;
+};
+
+static struct media_request_entity_data *
+alloc_req_data(struct media_request *req, struct media_entity *entity)
+{
+ struct media_request_entity_data_generic *ret;
+
+ ret = kzalloc(sizeof(*ret), GFP_KERNEL);
+ if (!ret)
+ return ERR_PTR(-ENOMEM);
+
+ return &ret->base;
+}
+
+static void release_req_data(struct media_request_entity_data *_data)
+{
+ struct media_request_entity_data_generic *data;
+
+ data = container_of(_data, typeof(*data), base);
+ kfree(data);
+}
+
+static int apply_req_data(struct media_request_entity_data *_data)
+{
+ return 0;
+}
+
+const struct media_request_entity_ops
+media_entity_request_generic_ops = {
+ .alloc_data = alloc_req_data,
+ .release_data = release_req_data,
+ .apply_data = apply_req_data,
+};
+EXPORT_SYMBOL_GPL(media_entity_request_generic_ops);
diff --git a/include/media/media-request.h b/include/media/media-request.h
index 583a1116f735..de3d6d824ffd 100644
--- a/include/media/media-request.h
+++ b/include/media/media-request.h
@@ -240,6 +240,11 @@ struct media_request_entity_ops {
int (*apply_data)(struct media_request_entity_data *data);
};
+/*
+ * Generic entity request support, built on top of standard V4L2 functions
+ */
+extern const struct media_request_entity_ops media_entity_request_generic_ops;
+
/**
* media_device_request_cmd() - perform the REQUEST_CMD ioctl
*
--
2.15.1.504.g5279b80103-goog
next prev parent reply other threads:[~2017-12-15 7:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 7:56 [RFC PATCH 0/9] media: base request API support Alexandre Courbot
2017-12-15 7:56 ` [RFC PATCH 1/9] media: add request API core and UAPI Alexandre Courbot
2017-12-15 10:37 ` Philippe Ombredanne
2018-01-12 10:16 ` Hans Verkuil
2018-01-26 8:39 ` Sakari Ailus
2018-01-30 4:23 ` Alexandre Courbot
2018-02-02 7:33 ` Sakari Ailus
2018-02-02 7:41 ` Tomasz Figa
2018-02-02 8:00 ` Hans Verkuil
2017-12-15 7:56 ` [RFC PATCH 2/9] media: request: add generic queue Alexandre Courbot
2017-12-15 7:56 ` Alexandre Courbot [this message]
2017-12-15 7:56 ` [RFC PATCH 4/9] videodev2.h: Add request field to v4l2_buffer Alexandre Courbot
2018-01-12 10:22 ` Hans Verkuil
2018-01-15 8:24 ` Alexandre Courbot
2017-12-15 7:56 ` [RFC PATCH 5/9] media: vb2: add support for requests Alexandre Courbot
2018-01-12 10:49 ` Hans Verkuil
2018-01-15 8:24 ` Alexandre Courbot
2018-01-15 9:07 ` Hans Verkuil
2018-01-16 9:39 ` Alexandre Courbot
2018-01-16 10:37 ` Hans Verkuil
2018-01-17 8:01 ` Alexandre Courbot
2018-01-17 8:37 ` Hans Verkuil
2017-12-15 7:56 ` [RFC PATCH 6/9] media: vb2: add support for requests in QBUF ioctl Alexandre Courbot
2018-01-12 11:37 ` Hans Verkuil
2018-01-15 8:24 ` Alexandre Courbot
2018-01-15 9:19 ` Hans Verkuil
2018-01-16 9:40 ` Alexandre Courbot
2017-12-15 7:56 ` [RFC PATCH 7/9] media: v4l2-mem2mem: add request support Alexandre Courbot
2017-12-15 7:56 ` [RFC PATCH 8/9] media: vim2m: add media device Alexandre Courbot
2017-12-15 7:56 ` [RFC PATCH 9/9] media: vim2m: add request support Alexandre Courbot
2017-12-18 20:53 ` Gustavo Padovan
2017-12-20 9:29 ` Alexandre Courbot
2017-12-15 21:02 ` [RFC PATCH 0/9] media: base request API support Nicolas Dufresne
2017-12-20 9:24 ` Alexandre Courbot
2017-12-15 21:04 ` Nicolas Dufresne
2017-12-20 9:27 ` Alexandre Courbot
2018-01-12 11:45 ` Hans Verkuil
2018-01-15 8:24 ` Alexandre Courbot
2018-01-15 8:43 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215075625.27028-4-acourbot@chromium.org \
--to=acourbot@chromium.org \
--cc=gustavo.padovan@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=posciak@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®