From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756501AbdLOKEu (ORCPT <rfc822;w@1wt.eu>);
        Fri, 15 Dec 2017 05:04:50 -0500
Received: from mx2.suse.de ([195.135.220.15]:43136 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753450AbdLOKEq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Dec 2017 05:04:46 -0500
Date: Fri, 15 Dec 2017 11:04:43 +0100
From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Huang, Ying" <ying.huang@intel.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>,
        Minchan Kim <minchan@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
        Tim Chen <tim.c.chen@linux.intel.com>, Shaohua Li <shli@fb.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        =?iso-8859-1?B?Suly9G1l?= Glisse <jglisse@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        David Rientjes <rientjes@google.com>, Rik van Riel <riel@redhat.com>,
        Jan Kara <jack@suse.cz>, Dave Jiang <dave.jiang@intel.com>,
        Aaron Lu <aaron.lu@intel.com>
Subject: Re: [PATCH -mm -V2] mm, swap: Fix race between swapoff and some swap
 operations
Message-ID: <20171215100443.GX16951@dhcp22.suse.cz>
References: <20171214133832.11266-1-ying.huang@intel.com>
 <20171214151718.GS16951@dhcp22.suse.cz>
 <20171214124246.ceebc9c955bd32601c01a28b@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171214124246.ceebc9c955bd32601c01a28b@linux-foundation.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu 14-12-17 12:42:46, Andrew Morton wrote:
> On Thu, 14 Dec 2017 16:17:18 +0100 Michal Hocko <mhocko@kernel.org> wrote:
> 
> > > as fast as possible, SRCU instead of reference count is used to
> > > implement get/put_swap_device().  From get_swap_device() to
> > > put_swap_device(), the reader side of SRCU is locked, so
> > > synchronize_srcu() in swapoff() will wait until put_swap_device() is
> > > called.
> > 
> > It is quite unfortunate to pull SRCU as a dependency to the core kernel.
> > Different attempts to do this have failed in the past. This one is
> > slightly different though because I would suspect that those tiny
> > systems do not configure swap. But who knows, maybe they do.
> > 
> > Anyway, if you are worried about performance then I would expect some
> > numbers to back that worry. So why don't simply start with simpler
> > ref count based and then optimize it later based on some actual numbers.
> > Btw. have you considered pcp refcount framework. I would suspect that
> > this would give you close to SRCU performance.
> 
> <squeaky-wheel>Or use stop_kernel() ;)</squeaky-wheel>

well, stop_kernel is a _huge_ hammer. I think we can do much better
without a large complexity. A simple ref counting (or pcp refcounting if
the former has measurable complexity) should do just fine.

-- 
Michal Hocko
SUSE Labs