mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: "Dmitry Vyukov" <dvyukov@google.com>,
	"Wanpeng Li" <kernellwp@gmail.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	syzbot
	<bot+1f445b1009b8eeededa30fe62ccf685f2ec9d155@syzkaller.appspotmail.com>,
	"Borislav Petkov" <bp@suse.de>,
	"Dmitry Safonov" <dsafonov@virtuozzo.com>,
	"Peter Anvin" <hpa@zytor.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Kyle Huey" <me@kylehuey.com>, "Ingo Molnar" <mingo@redhat.com>,
	syzkaller-bugs@googlegroups.com,
	"the arch/x86 maintainers" <x86@kernel.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"KVM list" <kvm@vger.kernel.org>,
	"Lan, Tianyu" <tianyu.lan@intel.com>,
	"James Mattson" <jmattson@google.com>
Subject: Re: BUG: unable to handle kernel paging request in __switch_to
Date: Fri, 15 Dec 2017 17:44:58 +0100	[thread overview]
Message-ID: <20171215164458.gyqzt2c5h3clpesc@gmail.com> (raw)
In-Reply-To: <CALCETrXkxXWGYoq1=SFuy3iugF36Fey0KpMdQ-2KLRwF1oEg7g@mail.gmail.com>


* Andy Lutomirski <luto@kernel.org> wrote:

> On Fri, Dec 15, 2017 at 2:02 AM, Dmitry Vyukov <dvyukov@google.com> wrote:
> > On Fri, Dec 15, 2017 at 10:58 AM, Wanpeng Li <kernellwp@gmail.com> wrote:
> >> 2017-12-15 17:51 GMT+08:00 David Hildenbrand <david@redhat.com>:
> >>>
> >>>> int main()
> >>>> {
> >>>>   int fd = open("/dev/kvm", 0x80102ul);
> >>>>   int vm = ioctl(fd, KVM_CREATE_VM, 0);
> >>>>   int  cpu = ioctl(vm, KVM_CREATE_VCPU, 4);
> >>>
> >>> Not even a memory region :) So maybe the first memory access directly
> >>> triggers a fault?
> >>>
> >>>>   ioctl(cpu, KVM_RUN, 0);
> >>>>   return 0;
> >>>> }
> >>>>
> >>>> And, yes, this in fact triggers instant reboot of kernel (running in qemu).
> >>>> Am I missing something here?
> >>>>
> >>>> +kvm maintainers, you can see full thread here:
> >>>> https://groups.google.com/forum/#!topic/syzkaller-bugs/_oveOKGm3jw
> >>
> >> I didn't see any issue after running the test.
> >
> > Yes, it's strange. But I can reproduce it. There must be something
> > different in our setups.
> > Here is how to build exact same kernel:
> > https://groups.google.com/d/msg/syzkaller-bugs/_oveOKGm3jw/vc1tXvsbCgAJ
> >
> > Here is how I start qemu:
> >
> > qemu-system-x86_64 -hda wheezy.img -net
> > user,host=10.0.2.10,hostfwd=tcp::10022-:22 -net nic -nographic -kernel
> > arch/x86/boot/bzImage -append "kvm-intel.nested=1
> > kvm-intel.unrestricted_guest=1 kvm-intel.ept=1
> > kvm-intel.flexpriority=1 kvm-intel.vpid=1
> > kvm-intel.emulate_invalid_guest_state=1 kvm-intel.eptad=1
> > kvm-intel.enable_shadow_vmcs=1 kvm-intel.pml=1
> > kvm-intel.enable_apicv=1 console=ttyS0 root=/dev/sda
> > earlyprintk=serial slub_debug=UZ vsyscall=native rodata=n oops=panic
> > panic_on_warn=1 panic=86400" -enable-kvm -pidfile vm_pid -m 2G -smp 4
> > -cpu host -usb -usbdevice mouse -usbdevice tablet -soundhw all
> >
> > The image is here:
> > https://github.com/google/syzkaller/blob/master/docs/syzbot.md#crash-does-not-reproduce
> >
> > Host cpu is Intel(R) Xeon(R) CPU E5-2690 v3
> 
> Looking more closely, you seem to be testing this:
> 
> commit d127129e85a020879f334154300ddd3f7ec21c1e (HEAD, tag: next-20171129)
> Author: Stephen Rothwell <s...@canb.auug.org.au>
> Date:   Wed Nov 29 14:09:56 2017 +1100
>     Add linux-next specific files for 20171129
> 
> which is almost certainly missing this fix:
> 
> https://lkml.kernel.org/r/bc7296f4c8d86af71c31a17588c79d89c0890edc.1512109321.git.luto@kernel.org
> 
> on account of the fix being sent the day after the tag.
> 
> The symptoms you're seeing are definitely consistent with a screwed up
> TSS after VM exit.

Note that this should all be fixed in WIP.x86/pti.

If you have:

  5ed1fcd523b9: x86/entry: Fix assumptions that the HW TSS is at the beginning of cpu_tss

then you should be fine.

Thanks,

	Ingo

  reply	other threads:[~2017-12-15 16:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <001a1145e8548cbd3d055f73374f@google.com>
2017-12-14 17:12 ` Thomas Gleixner
2017-12-14 18:42   ` Linus Torvalds
2017-12-14 18:54     ` Andy Lutomirski
2017-12-14 19:28       ` Linus Torvalds
2017-12-14 21:27         ` Andy Lutomirski
2017-12-14 21:39           ` Linus Torvalds
2017-12-15  9:07             ` Dmitry Vyukov
2017-12-15  9:13               ` Dmitry Vyukov
2017-12-15  9:38                 ` Dmitry Vyukov
2017-12-15  9:40                   ` Wanpeng Li
2017-12-15  9:51                   ` David Hildenbrand
2017-12-15  9:58                     ` Wanpeng Li
2017-12-15 10:02                       ` Dmitry Vyukov
2017-12-15 16:16                         ` Andy Lutomirski
2017-12-15 16:44                           ` Ingo Molnar [this message]
2017-12-19 11:48                             ` Dmitry Vyukov
2017-12-15  9:49               ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215164458.gyqzt2c5h3clpesc@gmail.com \
    --to=mingo@kernel.org \
    --cc=bot+1f445b1009b8eeededa30fe62ccf685f2ec9d155@syzkaller.appspotmail.com \
    --cc=bp@suse.de \
    --cc=david@redhat.com \
    --cc=dsafonov@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=me@kylehuey.com \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tglx@linutronix.de \
    --cc=tianyu.lan@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®