From: Benson Leung <bleung@google.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Benson Leung <bleung@chromium.org>,
Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cros_ec: fix nul-termination for firmware build info
Date: Fri, 15 Dec 2017 21:08:32 -0800 [thread overview]
Message-ID: <20171216050832.GB79455@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <20171204145014.479349-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 753 bytes --]
Hi Arnd,
On Mon, Dec 04, 2017 at 03:49:48PM +0100, Arnd Bergmann wrote:
> As gcc-8 reports, we zero out the wrong byte:
>
> drivers/platform/chrome/cros_ec_sysfs.c: In function 'show_ec_version':
> drivers/platform/chrome/cros_ec_sysfs.c:190:12: error: array subscript 4294967295 is above array bounds of 'uint8_t[]' [-Werror=array-bounds]
>
> This changes the code back to what it did before changing to a
> zero-length array structure.
>
> Fixes: a841178445bb ("mfd: cros_ec: Use a zero-length array for command data")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied. Thanks!
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-12-16 5:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 14:49 Arnd Bergmann
2017-12-16 5:08 ` Benson Leung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171216050832.GB79455@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=arnd@arndb.de \
--cc=bleung@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®