From: Al Viro <viro@ZenIV.linux.org.uk>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/usercopy: fix sparse errors
Date: Sun, 17 Dec 2017 17:31:24 +0000 [thread overview]
Message-ID: <20171217173124.GN21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171217172139.uytoormlzryy7pu5@ltop.local>
> The change is good.
> The commit message would better simply describe the problem instead
> of describing the symptom. For example, something like:
> The function _copy_to_user() is used to copy to address space.
> As such, the destination pointer should be annotated with
> '__user'.
> However, the function has the annotation wrongly, on the
> source instead of the destination (copy & paste error?).
> Fix this by moving the __user annotation to the correct
> argument.
FWIW, I've committed it with
Fix misannotated out-of-line _copy_to_user()
Destination is a kernel pointer and source - a userland one
is _copy_from_user(); _copy_to_user() is the other way round.
prev parent reply other threads:[~2017-12-17 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 16:24 Christophe Leroy
2017-12-17 17:21 ` Luc Van Oostenryck
2017-12-17 17:31 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171217173124.GN21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®