From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932444AbdLRESB (ORCPT ); Sun, 17 Dec 2017 23:18:01 -0500 Received: from mail-pf0-f172.google.com ([209.85.192.172]:36638 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932280AbdLRER7 (ORCPT ); Sun, 17 Dec 2017 23:17:59 -0500 X-Google-Smtp-Source: ACJfBouUmx9C4sY9yTF26pc66lFuh8gQkLbexCCQedEhD0cf/f4jgnujp8zPu3Ix1WJqjN9qHfYneA== Date: Mon, 18 Dec 2017 09:47:55 +0530 From: Viresh Kumar To: Mathieu Malaterre Cc: Rob Herring , Viresh Kumar , Shiraz Hashim , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/25] arm: spear: dts: Remove leading 0x and 0s from bindings notation Message-ID: <20171218041755.GA19815@vireshk-i7> References: <20171215124645.30535-1-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171215124645.30535-1-malat@debian.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-12-17, 13:46, Mathieu Malaterre wrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C > > For simplicity, two sed expressions were used to solve each warnings separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This will solve as a side effect warning: > > Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre > --- > arch/arm/boot/dts/spear1310-evb.dts | 4 ++-- > arch/arm/boot/dts/spear300.dtsi | 2 +- > arch/arm/boot/dts/spear310.dtsi | 2 +- > arch/arm/boot/dts/spear320-hmi.dts | 4 ++-- > arch/arm/boot/dts/spear320.dtsi | 2 +- > 5 files changed, 7 insertions(+), 7 deletions(-) Acked-by: Viresh Kumar -- viresh