From: Peter Zijlstra <peterz@infradead.org>
To: Alexei Starovoitov <ast@fb.com>
Cc: Teng Qin <qinteng@fb.com>,
mingo@redhat.com, bgregg@netflix.com, daniel@iogearbox.net,
yhs@fb.com, linux-kernel@vger.kernel.org, Kernel-team@fb.com
Subject: Re: [PATCH tip 0/3] Improvements of scheduler related Tracepoints
Date: Mon, 18 Dec 2017 10:11:57 +0100 [thread overview]
Message-ID: <20171218091157.rgogahbflgwvwcdw@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <e3777c2d-f267-b0cc-28ab-6c41e87c4ee7@fb.com>
On Fri, Dec 15, 2017 at 09:09:51AM -0800, Alexei Starovoitov wrote:
> yeah. Currently bpf progs are called at the end of
> perf_trace_##call()
> {
> .. regular tracepoint copy craft
> perf_trace_run_bpf_submit( &copied args )
> }
>
> from bpf pov we'd rather get access to raw args passed into
> perf_trace_##call.
> Sounds like you're suggesting to let bpf side register its
> progs directly via tracepoint_probe_register() ?
> That would solve the whole thing really nicely indeed.
Not sure I thought that far; but if you want the probe arguments either
grab them from the perf probe you're running in or indeed register your
own, don't play silly buggers and copy them in the trace data.
> How such api would look like ?
> Something like extending kprobe/uprobe fd-based perf_event_open?
> https://www.spinics.net/lists/netdev/msg470567.html
> btw could you please apply that set to tip tree
> or you want us to route it via bpf-next -> net-next ?
Oh right, lemme prod Ingo on that.
next prev parent reply other threads:[~2017-12-18 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 20:20 Teng Qin
2017-12-14 20:20 ` [PATCH tip 1/3] Improve sched_switch Tracepoint Teng Qin
2017-12-14 20:20 ` [PATCH tip 2/3] Improve sched_process_fork Tracepoint Teng Qin
2017-12-14 20:20 ` [PATCH tip 3/3] Improve sched_process_exit Tracepoint Teng Qin
2017-12-14 20:49 ` [PATCH tip 0/3] Improvements of scheduler related Tracepoints Peter Zijlstra
2017-12-15 3:16 ` Alexei Starovoitov
2017-12-15 7:39 ` Peter Zijlstra
2017-12-15 8:53 ` Teng Qin
2017-12-15 9:53 ` Peter Zijlstra
2017-12-15 17:09 ` Alexei Starovoitov
2017-12-18 9:11 ` Peter Zijlstra [this message]
2017-12-21 2:03 ` tracepoint_probe_register and bpf. Was: " Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218091157.rgogahbflgwvwcdw@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Kernel-team@fb.com \
--cc=ast@fb.com \
--cc=bgregg@netflix.com \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qinteng@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®