From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933643AbdLRJvU (ORCPT <rfc822;w@1wt.eu>);
        Mon, 18 Dec 2017 04:51:20 -0500
Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:42908 "EHLO
        mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1758455AbdLRJvF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Dec 2017 04:51:05 -0500
Authentication-Results: ppops.net;
        spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com
Date: Mon, 18 Dec 2017 09:50:48 +0000
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
CC: <alsa-devel@alsa-project.org>, Liam Girdwood <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, <linux-kernel@vger.kernel.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo
 Semiconductor's TSCS42xx audio CODECs
Message-ID: <20171218095048.e5zwla65f2qqmroj@localhost.localdomain>
References: <20171217035439.5merfdxrjz6amscd@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20171217035439.5merfdxrjz6amscd@localhost.localdomain>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0
 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011
 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000
 definitions=main-1712180129
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 16, 2017 at 09:54:50PM -0600, Steven Eckhoff wrote:
> Currently there is no support for TSCS42xx audio CODECs.
> 
> Add support for TSCS42xx audio CODECs.
> 
> Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
> ---
> +/* D2S Input Select */
> +static char const * const d2s_input_select_text[] = {
> +	"Line 1", "Line 2"
> +};
> +
> +static const struct soc_enum d2s_input_select_enum =
> +SOC_ENUM_SINGLE(R_INMODE, FB_INMODE_DS, ARRAY_SIZE(d2s_input_select_text),
> +		d2s_input_select_text);
> +
> +static const struct snd_kcontrol_new d2s_input_mux =
> +SOC_DAPM_ENUM("D2S_IN_MUX", d2s_input_select_enum);
> +

Is this unused?

> +#define COEFF_RAM_CTL(xname, xcount, xhandler_get, xhandler_put, xaddr) \
> +{	.iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \
> +	.info = bytes_info_ext, \
> +	.get = xhandler_get, .put = xhandler_put, \

Given all users of this macro use coeff_ram_get and coeff_ram_put
might it just be worth sticking them in here?

> +	.private_value = (unsigned long)&(struct coeff_ram_ctl) { \
> +		.addr = xaddr, \
> +		.bytes_ext = {.max = xcount, }, \
> +	} \
> +}

Other than those two very minor comments, looks ok to me so I
think you can add:

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles