From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758554AbdLRNov (ORCPT ); Mon, 18 Dec 2017 08:44:51 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:57994 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbdLRNos (ORCPT ); Mon, 18 Dec 2017 08:44:48 -0500 Date: Mon, 18 Dec 2017 13:44:30 +0000 From: Russell King - ARM Linux To: Arnd Bergmann Cc: Brian Norris , Gregory Fong , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Alamy Liu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: B15: fix unused label warnings Message-ID: <20171218134430.GD10595@n2100.armlinux.org.uk> References: <20171218134126.2913861-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171218134126.2913861-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 18, 2017 at 02:41:11PM +0100, Arnd Bergmann wrote: > The new conditionally compiled code leaves some labels and one > variable unreferenced when CONFIG_HOTPLUG_CPU and CONFIG_PM_SLEEP > are disabled: > > arch/arm/mm/cache-b15-rac.c: In function 'b15_rac_init': > arch/arm/mm/cache-b15-rac.c:353:1: error: label 'out_unmap' defined but not used [-Werror=unused-label] > out_unmap: > ^~~~~~~~~ > arch/arm/mm/cache-b15-rac.c:351:1: error: label 'out_cpu_dead' defined but not used [-Werror=unused-label] > out_cpu_dead: > ^~~~~~~~~~~~ > At top level: > arch/arm/mm/cache-b15-rac.c:53:12: error: 'rac_config0_reg' defined but not used [-Werror=unused-variable] > > This adds more #ifdefs around them. > > Fixes: 55de88778f4b ("ARM: 8726/1: B15: Add CPU hotplug awareness") > Signed-off-by: Arnd Bergmann > --- > Florian, if this looks good to you, please forward the fix into Russell's > patch tracker, otherwise just send a better fix. I'd prefer a better fix than yet more ifdefs... -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up