mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dhaval Shah <dhaval.shah@softnautics.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing semicolon
Date: Mon, 18 Dec 2017 16:02:00 +0100	[thread overview]
Message-ID: <20171218150200.GA15318@kroah.com> (raw)
In-Reply-To: <20171208081305.15153-4-dhaval.shah@softnautics.com>

On Fri, Dec 08, 2017 at 01:43:05PM +0530, Dhaval Shah wrote:
> Resolved all the macros should not use a trailing semicolon
> checkpatch warnings. Issue found by checkpatch.
> 
> Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
> ---
>  drivers/misc/ad525x_dpot.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
> index 577f5e76c8a8..bc591b7168db 100644
> --- a/drivers/misc/ad525x_dpot.c
> +++ b/drivers/misc/ad525x_dpot.c
> @@ -515,11 +515,11 @@ set_##_name(struct device *dev, \
>  #define DPOT_DEVICE_SHOW_SET(name, reg) \
>  DPOT_DEVICE_SHOW(name, reg) \
>  DPOT_DEVICE_SET(name, reg) \
> -static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name);
> +static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name)

This should be using DEVICE_ATTR_RW() instead of DEVICE_ATTR(), care to
fix that up in a follow-on patch for this driver?

thanks,

greg k-h

  reply	other threads:[~2017-12-18 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08  8:13 [PATCH 0/3] misc: ad525x_dpot: Different type of warnings are resolved Dhaval Shah
2017-12-08  8:13 ` [PATCH 1/3] misc: ad525x_dpot: Prefer 'unsigned int' to bare use of 'unsigned' Dhaval Shah
2017-12-08  8:13 ` [PATCH 2/3] misc: ad525x_dpot: please, no space before tabs Dhaval Shah
2017-12-08  8:13 ` [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing semicolon Dhaval Shah
2017-12-18 15:02   ` Greg KH [this message]
2017-12-19  5:18     ` Dhaval Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171218150200.GA15318@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=dhaval.shah@softnautics.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome