From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760354AbdLRUIq (ORCPT <rfc822;w@1wt.eu>);
        Mon, 18 Dec 2017 15:08:46 -0500
Received: from mail-ot0-f177.google.com ([74.125.82.177]:35889 "EHLO
        mail-ot0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758852AbdLRUIn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Dec 2017 15:08:43 -0500
X-Google-Smtp-Source: ACJfBouETa7alV+N/kgLpNwgjvbaophBRbjhS5RGsDMC9N62sD+ch2VgTnFb32HGZHfqZ8XiNnba1g==
Date: Mon, 18 Dec 2017 14:08:32 -0600
From: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo
 Semiconductor's TSCS42xx audio CODECs
Message-ID: <20171218195843.c4pp6ntsup2o4l5y@localhost.localdomain>
References: <20171217035439.5merfdxrjz6amscd@localhost.localdomain>
 <20171218095048.e5zwla65f2qqmroj@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171218095048.e5zwla65f2qqmroj@localhost.localdomain>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 18, 2017 at 09:50:48AM +0000, Charles Keepax wrote:

> Is this unused?

I apologize I missed this. These were going to be mux controls for two
differential inputs. There are two inputs, but only one can be used at
a time. We have never seen anybody use the second input, so I will
remove the mux controls since it is likely just going to be noise to
anybody configuring the chip through these controls.

> Given all users of this macro use coeff_ram_get and coeff_ram_put
> might it just be worth sticking them in here?

Good point. In the next version the callbacks will be implied through
the use of the macro.

> Other than those two very minor comments, looks ok to me so I
> think you can add:
> 
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> 
> Thanks,
> Charles

Thank you so much for your time on this review. It has really helped
improve the driver.