From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760599AbdLRUlm (ORCPT <rfc822;w@1wt.eu>);
        Mon, 18 Dec 2017 15:41:42 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:44371 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1760577AbdLRUlc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Dec 2017 15:41:32 -0500
Date: Mon, 18 Dec 2017 21:41:05 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andy Lutomirsky <luto@kernel.org>, Borislav Petkov <bpetkov@suse.de>,
        Greg KH <gregkh@linuxfoundation.org>, keescook@google.com,
        hughd@google.com, Brian Gerst <brgerst@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Rik van Riel <riel@redhat.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        David Laight <David.Laight@aculab.com>,
        Eduardo Valentin <eduval@amazon.com>, aliguori@amazon.com,
        Will Deacon <will.deacon@arm.com>, daniel.gruss@iaik.tugraz.at,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [patch V163 27/51] x86/mm/pti: Populate user PGD
Message-ID: <20171218204105.bs74dkixlbwfegb5@hirez.programming.kicks-ass.net>
References: <20171218114215.239543034@linutronix.de>
 <20171218115255.827361623@linutronix.de>
 <93e88e2c-50fc-49a6-7113-d9b64cf70fbd@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <93e88e2c-50fc-49a6-7113-d9b64cf70fbd@intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 18, 2017 at 12:34:22PM -0800, Dave Hansen wrote:
> On 12/18/2017 03:42 AM, Thomas Gleixner wrote:
> > --- a/arch/x86/include/asm/pgtable.h
> > +++ b/arch/x86/include/asm/pgtable.h
> > @@ -1120,6 +1120,11 @@ static inline void pmdp_set_wrprotect(st
> >  static inline void clone_pgd_range(pgd_t *dst, pgd_t *src, int count)
> >  {
> >         memcpy(dst, src, count * sizeof(pgd_t));
> > +#ifdef CONFIG_PAGE_TABLE_ISOLATION
> > +	/* Clone the user space pgd as well */
> > +	memcpy(kernel_to_user_pgdp(dst), kernel_to_user_pgdp(src),
> > +	       count * sizeof(pgd_t));
> > +#endif
> >  }
> 
> I was just thinking about this as I re-write the documentation about
> where the overhead of pti comes from.

The think I thought of when I saw this earlier today was that this could
trivially be wrapped in a static_cpu_has(X86_FEATURE_PTI).

> This obviously *works* for now.  But, we certainly have the pti-mapped
> stuff spread much less through the address space than when this was
> thrown in here.  It *seems* like we could probably do this with just 4 PGDs:
> 
> >         pti_clone_user_shared();
> >         pti_clone_entry_text();
> >         pti_setup_espfix64();
> >         pti_setup_vsyscall();
> 
> The vsyscall is just one page and the espfix is *sized* to be one PGD,
> so we know each of those only takes one entry.
> 
> We surely don't have 512GB of entry_text, and I don't think KASLR can
> ever cause it to span two PGD entries.
> 
> I also don't think the user_shared area of the fixmap can get *that*
> big.  Does anybody know offhand what the theoretical limits are there?

Problem there is the nr_cpus term I think, we currently have up to 8k
CPUs, but I can see that getting bigger in the future.