From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965932AbdLSOxk (ORCPT ); Tue, 19 Dec 2017 09:53:40 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51110 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935262AbdLSOxi (ORCPT ); Tue, 19 Dec 2017 09:53:38 -0500 Date: Tue, 19 Dec 2017 09:53:36 -0500 (EST) Message-Id: <20171219.095336.2222430428460536576.davem@davemloft.net> To: okaya@codeaurora.org Cc: andriy.shevchenko@linux.intel.com, linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, keescook@chromium.org, edumazet@google.com, tklauser@distanz.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot() From: David Miller In-Reply-To: References: <1513661883-28662-15-git-send-email-okaya@codeaurora.org> <1513680330.7000.167.camel@linux.intel.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Dec 2017 06:53:38 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sinan Kaya Date: Tue, 19 Dec 2017 07:17:41 -0500 > Then hard code the domain number as 0 while calling > pci_get_domain_bus_and_slot() if you know for sure that this device > will never work on a non-zero domain. Agreed, it's so much better to be explicit about this.