From: David Miller <davem@davemloft.net>
To: al.kochet@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, edumazet@google.com
Subject: Re: [PATCH] net: arc_emac: fix arc_emac_rx() error paths
Date: Tue, 19 Dec 2017 10:22:54 -0500 (EST) [thread overview]
Message-ID: <20171219.102254.1959679351283055093.davem@davemloft.net> (raw)
In-Reply-To: <1513358406-32503-1-git-send-email-al.kochet@gmail.com>
From: Alexander Kochetkov <al.kochet@gmail.com>
Date: Fri, 15 Dec 2017 20:20:06 +0300
> arc_emac_rx() has some issues found by code review.
>
> In case netdev_alloc_skb_ip_align() or dma_map_single() failure
> rx fifo entry will not be returned to EMAC.
>
> In case dma_map_single() failure previously allocated skb became
> lost to driver. At the same time address of newly allocated skb
> will not be provided to EMAC.
>
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
This patch adds quite a few bugs, here is one which shows this is not
functionally tested:
> - /* receive_skb only if new skb was allocated to avoid holes */
> - netif_receive_skb(skb);
> -
> - addr = dma_map_single(&ndev->dev, (void *)rx_buff->skb->data,
> + addr = dma_map_single(&ndev->dev, (void *)skb->data,
> EMAC_BUFFER_SIZE, DMA_FROM_DEVICE);
Map the new SKB.
> if (dma_mapping_error(&ndev->dev, addr)) {
> if (net_ratelimit())
> - netdev_err(ndev, "cannot dma map\n");
> - dev_kfree_skb(rx_buff->skb);
> + netdev_err(ndev, "cannot map dma buffer\n");
> + dev_kfree_skb(skb);
> + /* Return ownership to EMAC */
> + rxbd->info = cpu_to_le32(FOR_EMAC | EMAC_BUFFER_SIZE);
> stats->rx_errors++;
> + stats->rx_dropped++;
> continue;
> }
> +
> + /* unmap previosly mapped skb */
> + dma_unmap_single(&ndev->dev, dma_unmap_addr(rx_buff, addr),
> + dma_unmap_len(rx_buff, len), DMA_FROM_DEVICE);
And then you unmap it. "addr" is the new DMA mapping, not the old one.
next prev parent reply other threads:[~2017-12-19 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 17:20 Alexander Kochetkov
2017-12-19 11:03 ` [PATCH v2] net: arc_emac: restart stalled EMAC Alexander Kochetkov
2017-12-19 18:26 ` David Miller
2017-12-19 11:07 ` [PATCH v2] net: arc_emac: fix arc_emac_rx() error paths Alexander Kochetkov
2017-12-19 18:26 ` David Miller
2017-12-19 15:22 ` David Miller [this message]
2017-12-19 15:49 ` [PATCH] " Alexander Kochetkov
2017-12-19 16:41 ` David Miller
2017-12-19 18:33 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219.102254.1959679351283055093.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=al.kochet@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®