mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yisheng Xie <xieyisheng1@huawei.com>
Cc: thomas.lendacky@amd.com, lorenzo.pieralisi@arm.com, bp@suse.de,
	tglx@linutronix.de, kstewart@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] devres: use MACRO instead of function for devm_ioremap
Date: Tue, 19 Dec 2017 09:46:41 +0100	[thread overview]
Message-ID: <20171219084641.GA15010@kroah.com> (raw)
In-Reply-To: <1511601813-20533-1-git-send-email-xieyisheng1@huawei.com>

On Sat, Nov 25, 2017 at 05:23:33PM +0800, Yisheng Xie wrote:
> Default ioremap is ioremap_nocache, so devm_ioremap has the same function
> with devm_ioremap_nocache, which may just be killed. However, there are
> many places which use devm_ioremap_nocache, while many use devm_ioremap.
> 
> This patch is to use MACRO for devm_ioremap, which will reduce the size of
> devres.o from 206824 Bytes to 203768 Bytes.

Ok, the idea is good, but why not just get rid of the callers of
devm_ioremap_nocache() instead and have them call devm_ioremap() if they
really are the same thing?  No need to keep a macro around for the
duplicate thing, just delete the one and things are much better.

thanks,

greg k-h

  parent reply	other threads:[~2017-12-19  8:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-25  9:23 Yisheng Xie
2017-12-11  8:23 ` Yisheng Xie
2017-12-18 14:40   ` Greg KH
2017-12-19  1:31     ` Yisheng Xie
2017-12-19  8:46 ` Greg KH [this message]
2017-12-19 10:52   ` Yisheng Xie
2017-12-21 11:50     ` Yisheng Xie
2017-12-21 15:08       ` Greg KH
2017-12-22  9:06         ` Yisheng Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171219084641.GA15010@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bp@suse.de \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=xieyisheng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome