From: Mark Brown <broonie@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6] mfd: syscon: Add hardware spinlock support
Date: Tue, 19 Dec 2017 09:21:49 +0000 [thread overview]
Message-ID: <20171219092149.GB8563@sirena.org.uk> (raw)
In-Reply-To: <CAMz4kuK2JRSZt6BiYu+YRy_+kXNen+NTgayqpXy1n3qL-T9OzQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On Tue, Dec 19, 2017 at 02:55:47PM +0800, Baolin Wang wrote:
> Um, why regmap doesn't accept a zero lock-id, that because regmap will
> reguest hwlock depending on the 'regmap_config->hwlock_id' is not
> zero, if regmap regard a zero lock-id as valid which will affect other
> 'struct regmap_config' definition. So users should not assign the zero
> lock-id to regmap.
> Now of_hwspin_lock_get_id() can return 0 as valid, which depend on
> what is the base id registered by hwspinlock driver. So you think we
> should not regard 0 as valid from of_hwspin_lock_get_id(), I can try
> to send another patch to fix.
If 0 is a valid hwspinlock ID you need to add a flag to the regmap
config to say if a hwspinlock should be used. That way we're not
rejecting valid values.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-12-19 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:33 Baolin Wang
2017-12-15 10:42 ` Lee Jones
2017-12-15 13:13 ` Arnd Bergmann
2017-12-18 6:54 ` Baolin Wang
2017-12-18 12:44 ` Arnd Bergmann
2017-12-19 6:55 ` Baolin Wang
2017-12-19 9:21 ` Mark Brown [this message]
2017-12-19 11:05 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219092149.GB8563@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®