From: Arnd Bergmann <arnd@arndb.de>
To: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Alexei Starovoitov <ast@kernel.org>, Josef Bacik <jbacik@fb.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] bpf: fix BPF_KPROBE_OVERRIDE dependencies
Date: Tue, 19 Dec 2017 11:12:04 +0100 [thread overview]
Message-ID: <20171219101231.2139885-1-arnd@arndb.de> (raw)
CONFIG_BPF_KPROBE_OVERRIDE causes a link failure when CONFIG_KPROBE_EVENTS
is disabled:
kernel/trace/bpf_trace.o: In function `bpf_override_return':
(.text+0x172): undefined reference to `bpf_kprobe_override'
This adds it to the list of dependencies.
Fixes: 9802d86585db ("bpf: add a bpf_override_function helper")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/trace/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index ace4547b7564..0d83668652ef 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -534,6 +534,7 @@ config FUNCTION_PROFILER
config BPF_KPROBE_OVERRIDE
bool "Enable BPF programs to override a kprobed function"
depends on BPF_EVENTS
+ depends on KPROBE_EVENTS
depends on KPROBES_ON_FTRACE
depends on HAVE_KPROBE_OVERRIDE
depends on DYNAMIC_FTRACE_WITH_REGS
--
2.9.0
next reply other threads:[~2017-12-19 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 10:12 Arnd Bergmann [this message]
2017-12-19 23:11 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219101231.2139885-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=jbacik@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®