From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753699AbdLSPcb (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 10:32:31 -0500
Received: from mail-pl0-f45.google.com ([209.85.160.45]:41827 "EHLO
        mail-pl0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753583AbdLSPc3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 10:32:29 -0500
X-Google-Smtp-Source: ACJfBos8pvAjYSbvC3zIeWzr8yrtUImEtOlf6IM/efe57twRD0asG3Kn5jreoDvaxIz6XLbCUlYR8w==
Date: Wed, 20 Dec 2017 00:32:24 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Fengguang Wu <fengguang.wu@intel.com>,
        Kevin Hilman <khilman@baylibre.com>, Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCHv2] printk: add console_msg_format command line option
Message-ID: <20171219153224.GB591@tigerII.localdomain>
References: <20171219084243.1549-1-sergey.senozhatsky@gmail.com>
 <20171219101727.15ddb486@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171219101727.15ddb486@gandalf.local.home>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On (12/19/17 10:17), Steven Rostedt wrote:
[..]
> > +	console_msg_format=
> > +			[KNL] Change console messages format
> > +		default
> > +			By default we print messages on consoles in
> > +			"[time stamp] text\n" format (time stamp may not be
> > +			printed, depending on CONFIG_PRINTK_TIME or
> > +			`printk_time' param).
> > +		syslog
> > +			Switch to syslog format: "<%u>[time stamp] text\n"
> > +			IOW, each message will have a facility and loglevel
> > +			prefix. The format is similar to one used by syslog()
> > +			syscall, or to executing "dmesg -S --raw" or to reading
> > +			from /proc/kmsg.
> 
> Just to clarify. This affects all consoles, not just serial?

yes.

just like printk_time param/config option affects all the consoles,
console_msg_format affects all of them. we msg_print_text() once, that
makes messages look the same on every console. so I kept the existing
behaviour.

[..]
> > +enum con_msg_format {
> > +	MSG_FORMAT_DEFAULT	= 0,
> > +	MSG_FORMAT_SYSLOG	= (1 << 0),
> > +};
> 
> So the con_msg_format will be a flag (as denoted with the (1<<0)).
> Should we call it "con_msg_format_flags" to make it more obvious that
> these are treated as flags and not a simple number.

ok, can do.

[..]
> > +static int __init console_msg_format_setup(char *str)
> > +{
> > +	if (!strncmp(str, "syslog", 6))
> > +		console_msg_format = MSG_FORMAT_SYSLOG;
> > +	if (!strncmp(str, "default", 7))
> 
> You can use strcmp() instead of strncmp(), the init code will nul
> terminate the string for you before calling this function. Otherwise if
> we add "syslog_special" or "default_extra" they will be confused with
> the above.

ok, that's a minor thing, but can change.

	-ss