From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751865AbdLSSsb (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 13:48:31 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:55805 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750798AbdLSSs0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 13:48:26 -0500
Date: Tue, 19 Dec 2017 19:48:11 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Viresh Kumar <viresh.kumar@linaro.org>, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>,
        Chris Redpath <Chris.Redpath@arm.com>,
        Steve Muckle <smuckle@google.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Morten Ramussen <morten.rasmussen@arm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Saravana Kannan <skannan@quicinc.com>,
        Vikram Mulukutla <markivx@codeaurora.org>,
        Rohit Jain <rohit.k.jain@oracle.com>,
        Atish Patra <atish.patra@oracle.com>, Josef Bacik <jbacik@fb.com>,
        Rik van Riel <riel@redhat.com>, EAS Dev <eas-dev@lists.linaro.org>
Subject: Re: [PATCH RESEND] cpufreq: schedutil: Use idle_calls counter of the
 remote CPU
Message-ID: <20171219184811.campbfjw3plynurs@hirez.programming.kicks-ass.net>
References: <20171219174712.13806-1-joelaf@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171219174712.13806-1-joelaf@google.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 19, 2017 at 09:47:12AM -0800, Joel Fernandes wrote:
> Since the recent remote cpufreq callback work, its possible that a cpufreq
> update is triggered from a remote CPU. For single policies however, the current
> code uses the local CPU when trying to determine if the remote sg_cpu entered
> idle or is busy. This is incorrect. To remedy this, compare with the nohz tick
> idle_calls counter of the remote CPU.
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Joel Fernandes <joelaf@google.com>

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

> ---
> Just resending this which is cpufreq-related as requested by Rafael rebased
> on linus/master.
> 
> The other 2 patches in my last series which can go in independent of this one are:
> https://patchwork.kernel.org/patch/10115395/
> https://patchwork.kernel.org/patch/10115401/
> I'm still waiting on scheduler maintainers to comment on those. Unfortunately,
> I haven't heard back anything yet since the last repost of those.

Both of us have been somewhat preoccupied with that whole kaiser/pti
thing the past few weeks.

I have an absolutely stupid backlog :/