mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sven.eckelmann@openmesh.com
Cc: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org,
	willemdebruijn.kernel@gmail.com, tom@herbertland.com,
	jiri@mellanox.com, linux-kernel@vger.kernel.org,
	edumazet@google.com
Subject: Re: [PATCH v4 0/5] flow_dissector: Provide basic batman-adv unicast handling
Date: Thu, 21 Dec 2017 15:40:13 -0500 (EST)	[thread overview]
Message-ID: <20171221.154013.465159930243668403.davem@davemloft.net> (raw)
In-Reply-To: <20171221091742.8020-1-sven.eckelmann@openmesh.com>

From: Sven Eckelmann <sven.eckelmann@openmesh.com>
Date: Thu, 21 Dec 2017 10:17:37 +0100

> we are currently starting to use batman-adv as mesh protocol on multicore
> embedded devices. These usually don't have a lot of CPU power per core but
> are reasonable fast when using multiple cores.
> 
> It was noticed that sending was working very well but receiving was
> basically only using on CPU core per neighbor. The reason for that is
> format of the (normal) incoming packet:
> 
>   +--------------------+
>   | ip(v6)hdr          |
>   +--------------------+
>   | inner ethhdr       |
>   +--------------------+
>   | batadv unicast hdr |
>   +--------------------+
>   | outer ethhdr       |
>   +--------------------+
> 
> The flow dissector will therefore stop after parsing the outer ethernet
> header and will not parse the actual ipv(4|6)/... header of the packet. Our
> assumption was now that it would help us to add minimal support to the flow
> dissector to jump over the batman-adv unicast and inner ethernet header
> (like in gre ETH_P_TEB). The patch was implemented in a slightly hacky
> way [1] and the results looked quite promising.
> 
> I didn't get any feedback how the files should actually be named. So I am
> now just using the names from RFC v3
> 
> The discussion of the RFC v3 can be found in the related patches of
> https://patchwork.ozlabs.org/cover/849345/
> 
> The discussion of the RFC v2 can be found in the related patches of
> https://patchwork.ozlabs.org/cover/844783/

Series applied, thanks!

      parent reply	other threads:[~2017-12-21 20:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21  9:17 Sven Eckelmann
2017-12-21  9:17 ` [PATCH v4 1/5] batman-adv: Let packet.h include its headers directly Sven Eckelmann
2017-12-21  9:17 ` [PATCH v4 2/5] batman-adv: Remove usage of BIT(x) in packet.h Sven Eckelmann
2017-12-21  9:17 ` [PATCH v4 3/5] batman-adv: Remove kernel fixed width types " Sven Eckelmann
2017-12-21  9:17 ` [PATCH v4 4/5] batman-adv: Convert packet.h to uapi header Sven Eckelmann
2017-12-21  9:17 ` [PATCH v4 5/5] flow_dissector: Parse batman-adv unicast headers Sven Eckelmann
2017-12-21 12:24   ` Jiri Pirko
2017-12-21 16:58     ` Willem de Bruijn
2017-12-21 20:40 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221.154013.465159930243668403.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=edumazet@google.com \
    --cc=jiri@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sven.eckelmann@openmesh.com \
    --cc=tom@herbertland.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®