From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965640AbdLVJHv (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Dec 2017 04:07:51 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:42488 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965454AbdLVJGG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Dec 2017 04:06:06 -0500
Date: Fri, 22 Dec 2017 09:56:03 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: "lpc.li" <lpc.li@huawei.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, lidongpo@hisilicon.com
Subject: Re: usb: gadget: function: f_rndis:use dev_kfree_skb_irq instead of
 dev_kfree_skb
Message-ID: <20171222085603.GB18475@kroah.com>
References: <9d873444-19e8-37b2-e08f-d24d89a0959f@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9d873444-19e8-37b2-e08f-d24d89a0959f@huawei.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 22, 2017 at 04:44:48PM +0800, lpc.li wrote:
> We can't use kfree_skb in irq disable context, because spin_lock_irqsave
> make sure we are always in irq disable context, use dev_kfree_skb_irq
> instead of kfree_skb is better than dev_kfree_skb_any.

Ok, but your patch uses:

>  -   dev_kfree_skb(skb);
>  +   dev_kfree_skb_any(skb);

the _any call, not _irq, did you test this?

thanks,

greg k-h