From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756585AbdLVQGN (ORCPT ); Fri, 22 Dec 2017 11:06:13 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:40077 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756215AbdLVQGK (ORCPT ); Fri, 22 Dec 2017 11:06:10 -0500 X-Google-Smtp-Source: ACJfBosz4htGGzwlXG0haNsLveDy/UiGDAQsdprYn5AvK2eveBe/LL4HoHYfKeLht4NbTU9X2+kl8A== Date: Fri, 22 Dec 2017 09:06:07 -0700 From: Jason Gunthorpe To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Jarkko Sakkinen , Peter Huewe , Greg Kroah-Hartman , linux-integrity@vger.kernel.org Subject: Re: [PATCH] tpm: remove unused data fields from I2C and OF device ID tables Message-ID: <20171222160607.GA30884@ziepe.ca> References: <20171222102636.12530-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171222102636.12530-1-javierm@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 22, 2017 at 11:26:36AM +0100, Javier Martinez Canillas wrote: > The data field for the entries in the device tables are set but not used. > > Signed-off-by: Javier Martinez Canillas > > drivers/char/tpm/tpm_i2c_infineon.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c > index 005c38879b2e..19fbd6a3a8e9 100644 > +++ b/drivers/char/tpm/tpm_i2c_infineon.c > @@ -665,9 +665,9 @@ static int tpm_tis_i2c_init(struct device *dev) > } > > static const struct i2c_device_id tpm_tis_i2c_table[] = { > - {"tpm_i2c_infineon", 0}, > - {"slb9635tt", 0}, > - {"slb9645tt", 1}, > + {"tpm_i2c_infineon" }, > + {"slb9635tt" }, > + {"slb9645tt" }, ^^^ The space should go too.. Jason