From: Borislav Petkov <bp@suse.de>
To: Juergen Gross <jgross@suse.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Bug in patch "x86/pti: Add the pti= cmdline option and documentation"
Date: Fri, 22 Dec 2017 17:43:34 +0100 [thread overview]
Message-ID: <20171222164334.eyiyudqqj5wpenrr@pd.tnic> (raw)
In-Reply-To: <52b2f3c6-2e5e-2033-87d6-5abb3eb27b35@suse.com>
On Fri, Dec 22, 2017 at 05:41:32PM +0100, Juergen Gross wrote:
> The patch in the tip tree with commit 506bcdf68b07a0335751e1fe8be37
> ("x86/pti: Add the pti= cmdline option and documentation") is completely
> wrong: cmdline_find_option() will return -1 in case the otion isn't
> found and the len of the argument in case it has been found.
It is not completely wrong - we still walk into the if-branch. Besides,
we moved the xen check upwards, before that so it is not relevant for
the xen case.
Regardless, I'll send a correction soon to check the retval directly.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2017-12-22 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 16:41 Juergen Gross
2017-12-22 16:43 ` Borislav Petkov [this message]
2017-12-22 16:43 ` Thomas Gleixner
2017-12-22 16:54 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222164334.eyiyudqqj5wpenrr@pd.tnic \
--to=bp@suse.de \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®