From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pravin Shedge <pravin.shedge4linux@gmail.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
leonro@mellanox.com, saeedm@mellanox.com
Subject: Re: [PATCH 07/45] drivers: infiniband: remove duplicate includes
Date: Fri, 22 Dec 2017 09:45:22 -0700 [thread overview]
Message-ID: <20171222164522.GA20267@ziepe.ca> (raw)
In-Reply-To: <1512578979-5115-1-git-send-email-pravin.shedge4linux@gmail.com>
On Wed, Dec 06, 2017 at 10:19:39PM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@gmail.com>
> drivers/infiniband/core/mad.c | 1 -
> drivers/infiniband/core/netlink.c | 2 --
> drivers/infiniband/hw/mlx5/main.c | 4 +---
> drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 1 -
> drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 1 -
> 5 files changed, 1 insertion(+), 8 deletions(-)
I applied this to for-next, thanks
> index 543d0a4..fe435ed 100644
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -50,16 +50,14 @@
> #include <rdma/ib_cache.h>
> #include <linux/mlx5/port.h>
> #include <linux/mlx5/vport.h>
> +#include <linux/mlx5/fs.h>
> #include <linux/list.h>
> #include <rdma/ib_smi.h>
> #include <rdma/ib_umem.h>
> #include <linux/in.h>
> #include <linux/etherdevice.h>
> -#include <linux/mlx5/fs.h>
> -#include <linux/mlx5/vport.h>
> #include "mlx5_ib.h"
> #include "cmd.h"
> -#include <linux/mlx5/vport.h>
Yep, ugh.
Jason
prev parent reply other threads:[~2017-12-22 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 16:49 Pravin Shedge
2017-12-22 16:45 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222164522.GA20267@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=pravin.shedge4linux@gmail.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®