From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbdLXSXW (ORCPT ); Sun, 24 Dec 2017 13:23:22 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:40800 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbdLXSXS (ORCPT ); Sun, 24 Dec 2017 13:23:18 -0500 X-Google-Smtp-Source: ACJfBotw7N4GeBdp0K2FVPp9bo8eO+spKaZISaZ94lmwqsP7NBrJ/gYFoFtkb6/Cn509hzUoYP1UzA== Date: Sun, 24 Dec 2017 18:23:15 +0000 From: Aaron Tomlin To: Jiri Olsa Cc: acme@kernel.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH/RFC] perf report: Add option to change offset format when address is specified as a sort_key Message-ID: <20171224182315.xhz5n2z6dkibthzc@atomlin.usersys.com> References: <20171215153510.14499-1-atomlin@redhat.com> <20171222235941.GA22304@krava> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pcf5covnu54qsq7c" Content-Disposition: inline In-Reply-To: <20171222235941.GA22304@krava> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pcf5covnu54qsq7c Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat 2017-12-23 00:59 +0100, Jiri Olsa wrote: [ ... ] > not sure we've already discussed that, but this could be default? Probably it is best to keep the default behaviour. I'd prefer a hexadecimal address offset, as the default, however perhaps someone is happy with the current default (decimal). > if not, I think the hex option should be part of -g option arg, maybe lik= e: Does it have to be? > -g graph,callee,xaddress Not sure - adding another sort_key seems odd to me. But if you insist, perhaps address[=3Dhex] would be cleaner? Otherwise I would prefer --hex. Regards, --=20 Aaron Tomlin --pcf5covnu54qsq7c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJaP/CTAAoJEOLellgZzHfWwrkP/jK9PxmEfFAOW+sLRSkzLyy1 OJRQrdUPPdqAkzSRlLpNtqMJn11f8OW0uO39GH2wtjjToKRcxLs2l3UhMDA5I+5q VzqYUM3PlEvHSihV1zI88T0+SiNutaBtlnBfUS1V4SxzqoJ+ELeAvsw7f0ancmtT ZlE9JPE7YJu1RQFshg6wVzvCWYJMx00fd7fA+2jf9R7DtRRgYrOMNAYthCL6P3V/ L4RWgCekx6W+6FbsFhw4qw2ymQfGuv4IioHoqsHnLPLWYpupzalfnw/cuCSPkx08 8Zuw/jskuBICjI4QQb4Adq//xGt700g9p8CdahHYnURHv1DkbFRE9aYAiWjSMdei ot9J9n/oVFjWZGxWpq+DAUtZjeQI4tWJwATcUsKanjw29kgQA0EvzX2sJyNAuxF/ 2zBoijb44hprlOOQGcn+OwZipWUldq+YjmW+pVdtTC+Qf3ronTW14J3Q6CYlBver t9KLPA8NpKsldueaaUVfbN4ShY9qdZaP9z4iqqvZlD4tPN4JLF3fQCRbZKaA8HaQ n8jPKHCi7Ui5P92MgQ16uJ6mD9pNh1ONNxdop3q8PupmOqzkDt26YD9XXwQ5+DmA QGomuGgmk1iRvMhiQdzK0HENclRpnpG0PTc9j7MDJQVg+xdnP1ynkF5uMfvYWzwA xNYIR9dXKbsr/nBsjP2n =RzPs -----END PGP SIGNATURE----- --pcf5covnu54qsq7c--