From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbdLYCW7 (ORCPT ); Sun, 24 Dec 2017 21:22:59 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:46742 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbdLYCW4 (ORCPT ); Sun, 24 Dec 2017 21:22:56 -0500 X-Google-Smtp-Source: ACJfBovWzmo4Q0NHR7aFy1Pc6cHWivlC8ukwg2wDSA5f+MvzHoEe589ZLuST9bnEgenhbR0PaQ8wUg== From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: James Ettle , Hans de Goede , Azhar Shaikh , Javier Martinez Canillas , Jason Gunthorpe , linux-integrity@vger.kernel.org, Peter Huewe , Jarkko Sakkinen Subject: [PATCH v2 0/3] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled Date: Mon, 25 Dec 2017 03:22:48 +0100 Message-Id: <20171225022251.6464-1-javierm@redhat.com> X-Mailer: git-send-email 2.14.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell systems") added logic in the TPM TIS driver to disable the Low Pin Count CLKRUN signal during TPM transactions. Unfortunately this breaks other devices that are attached to the LPC bus like for example PS/2 mouse and keyboards. The bug was reported to the Fedora kernel [0] and the kernel bugzilla [1]. This issue and the propossed solution were discussed in this [2] thread, and the reporter (Jame Ettle) confirmed that his system works again after the fix in this series. The patches are based on top or Jarkko Sakkinen's linux-tpmdd [3] tree. Changes since v1: - Add collected tags - Drop patch that fixed a bug in the error path since was already fixed. [0]: https://bugzilla.redhat.com/show_bug.cgi?id=1498987 [1]: https://bugzilla.kernel.org/show_bug.cgi?id=197287 [2]: https://patchwork.kernel.org/patch/10119417/ [3]: git.infradead.org/users/jjs/linux-tpmdd.git Best regards, Javier Javier Martinez Canillas (3): tpm: delete the TPM_TIS_CLK_ENABLE flag tpm: follow coding style for variable declaration in tpm_tis_core_init() tpm: only attempt to disable the LPC CLKRUN if is already enabled drivers/char/tpm/tpm_tis.c | 15 --------------- drivers/char/tpm/tpm_tis_core.c | 17 +++++++++++++---- drivers/char/tpm/tpm_tis_core.h | 1 - 3 files changed, 13 insertions(+), 20 deletions(-) -- 2.14.3