From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbdLZR1r (ORCPT ); Tue, 26 Dec 2017 12:27:47 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55482 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbdLZR1p (ORCPT ); Tue, 26 Dec 2017 12:27:45 -0500 Date: Tue, 26 Dec 2017 12:27:43 -0500 (EST) Message-Id: <20171226.122743.1534786850925610235.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nsekhar@ti.com Subject: Re: [PATCH] net: phy: micrel: ksz9031: reconfigure autoneg after phy autoneg workaround From: David Miller In-Reply-To: <20171221004510.29715-1-grygorii.strashko@ti.com> References: <20171221004510.29715-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Dec 2017 09:27:45 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Wed, 20 Dec 2017 18:45:10 -0600 > Under some circumstances driver will perform PHY reset in > ksz9031_read_status() to fix autoneg failure case (idle error count = > 0xFF). When this happens ksz9031 will not detect link status change any > more when connecting to Netgear 1G switch (link can be recovered sometimes by > restarting netdevice "ifconfig down up"). Reproduced with TI am572x board > equipped with ksz9031 PHY while connecting to Netgear 1G switch. > > Fix the issue by reconfiguring autonegotiation after PHY reset in > ksz9031_read_status(). > > Fixes: d2fd719bcb0e ("net/phy: micrel: Add workaround for bad autoneg") > Signed-off-by: Grygorii Strashko Applied and queued up for -stable.