From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751233AbdLZQyr (ORCPT ); Tue, 26 Dec 2017 11:54:47 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:45668 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdLZQyo (ORCPT ); Tue, 26 Dec 2017 11:54:44 -0500 X-Google-Smtp-Source: ACJfBosD5r8hfUX7lhuZAEmmk2RlIhBoYUtgHrnocU0r1dUDMPpdyVfwunfa6GCuWaszv61fjyFWFQ== Date: Tue, 26 Dec 2017 19:54:40 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, Matthew Wilcox , Ross Zwisler , David Howells , Shaohua Li , Jens Axboe , Rehas Sachdeva , Marc Zyngier , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-usb@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH v5 03/78] xarray: Add the xa_lock to the radix_tree_root Message-ID: <20171226165440.tv6inwa2fgk3bfy6@node.shutemov.name> References: <20171215220450.7899-1-willy@infradead.org> <20171215220450.7899-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171215220450.7899-4-willy@infradead.org> User-Agent: NeoMutt/20171208 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 15, 2017 at 02:03:35PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > This results in no change in structure size on 64-bit x86 as it fits in > the padding between the gfp_t and the void *. The patch does more than described in the subject and commit message. At first I was confused why do you need to touch idr here. It took few minutes to figure it out. Could you please add more into commit message about lockname and xa_ locking interface since you introduce it here? -- Kirill A. Shutemov