From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Nick Desaulniers <nick.desaulniers@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] objtool: Fix clang enum conversion warning
Date: Wed, 27 Dec 2017 11:38:19 -0600 [thread overview]
Message-ID: <20171227173819.67iidrynd7jmmbmy@treble> (raw)
In-Reply-To: <alpine.DEB.2.20.1712271313260.3177@hsp>
On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote:
>
> On Tue, 26 Dec 2017, Nick Desaulniers wrote:
>
> > I sent a similar one recently:
> > https://patchwork.kernel.org/patch/10131815/ (maybe Josh is just
> > forwarding me an earlier fix?)
> >
> > Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> >
>
> I actually submitted this (other) patch to LKML on 2017-12-10:
>
> https://patchwork.kernel.org/patch/10103977/
>
> I also pointed this out on the llvmlinux mailing list:
>
> https://lists.linuxfoundation.org/pipermail/llvmlinux/2017-December/001535.html
>
> (The mail might not have been distributed yet to its recipients, because I
> am on the llvmlinux mailing list only for a few days, and I might have not
> been whitelisted for getting through the spam filtering of that list.)
>
> Nick submitted another patch to LKML on 2017-12-24 (see above).
>
> The source code change is the same; but the commit message was different.
> Now the third patch from Josh here is another equal patch with yet another
> commit message, combining information from both patches.
>
> Assuming that the authorship of this one-line change does not matter, as it
> is largely suggested by the clang compiler anyway, and we want to move the
> change forward, we should decide on which of three patches to move
> forward. I can give my Reviewed-by and Tested-by to any of them.
The patch from Lukas was the first one I received, so that's the one I
used. I rewrote the commit msg for clarity and added my SOB and sent it
to Ingo for merging.
--
Josh
next prev parent reply other threads:[~2017-12-27 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 21:27 Josh Poimboeuf
2017-12-27 0:35 ` Nick Desaulniers
2017-12-27 12:34 ` Lukas Bulwahn
2017-12-27 17:38 ` Josh Poimboeuf [this message]
2017-12-28 3:42 ` Nick Desaulniers
2017-12-28 5:12 ` Josh Poimboeuf
2017-12-28 12:09 ` Ingo Molnar
2017-12-28 8:18 ` Lukas Bulwahn
2017-12-28 15:37 ` [tip:core/urgent] objtool: Fix Clang " tip-bot for Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227173819.67iidrynd7jmmbmy@treble \
--to=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mingo@kernel.org \
--cc=nick.desaulniers@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®