From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751580AbdL1GPY (ORCPT ); Thu, 28 Dec 2017 01:15:24 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:59659 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdL1GPX (ORCPT ); Thu, 28 Dec 2017 01:15:23 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171228061521epoutp017da826ffe204a44759c0409fb47ef74d~EYLjDM6au1760717607epoutp01q X-AuditID: b6c32a4a-b91ff70000001151-62-5a448bf8e3db Mime-Version: 1.0 Subject: RE: [PATCH v2] ftrace/module: Move ftrace_release_mod to ddebug_cleanup label Reply-To: gupta.namit@samsung.com From: NAMIT GUPTA To: "rostedt@goodmis.org" CC: "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , PANKAJ MISHRA , AMIT SAHRAWAT X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <1513079672-13652-1-git-send-email-gupta.namit@samsung.com> X-Drm-Type: Y,confirm X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20171228051419epcms5p1ba575801dccdf1ebbefa956a80be231d@epcms5p1> Date: Thu, 28 Dec 2017 05:14:19 +0000 X-CMS-MailID: 20171228051419epcms5p1ba575801dccdf1ebbefa956a80be231d Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: REQ_APPROVE X-MTR: 20171228051419epcms5p1ba575801dccdf1ebbefa956a80be231d CMS-TYPE: 105P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPKsWRmVeSWpSXmKPExsWy7bCmhu6Pbpcog62NkhYXd6daXN41h83i 0oEFTBb33mxlstjX8YDJgdWjZd8tdo/3+66yefRtWcXo8XmTXABLVKpNRmpiSmqRQmpecn5K Zl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBaJYWyxJxSoFBAYnGxkr6dTVF+ aUmqQkZ+cYmtUrShoZGeoYG5npGRkZ6JaayVkSlQSUJqxoTN6xgLPilU3Nk2na2BsUWhi5GD Q0LARGLL8fwuRk4OIYHdjBLLW/lAwrwCghJ/dwiDhIUFIiRObV/PDFGiKNE7dT8LRFxX4t+N D6wgNpuAtsS2Y6uYQVpFBPQlFvwy7mLk4mAW2MUosXvOd7B6CQFeiRntT6FsaYnty7cygtic Ah4S965+ZoKIi0r8aYCpEZV4f2w+I4QtItF67ywzhC0o8eDnbqi4jMTHM3dYQZZJCPQzSpye /5kFwlkPtHn5Bqip5hLnT84H6+YV8JXY23caLM4ioCpx42wn1DYXiSkHP4DFmYG+WbbwNdg3 zAKaEut36UOUyEpMPbUOaqStxKV3v1kgyvkken8/YYJ5csc8GFtVYsfVI+yQYJaWmL3cACLs IXH9w0PmCYxKsxAhPQvJ3lkIexcwMq9ilEwtKM5NTy02LTDKSy3XK07MLS7NS9dLzs/dxAhO fFpeOxiXnfM5xCjAwajEw/tCziVKiDWxrLgy9xCjBAezkghvXrtzlBBvSmJlVWpRfnxRaU5q 8SFGU2AITGSWEk3OByblvJJ4QxNLAxMzM3NDAwNLEyVxXsdAoDkC6YklqdmpqQWpRTB9TByc Ug2M5Vtknuh+mn7ineqm3wuKzix7wvL6YJZbvbMwQ5rwwWgrWY8Op5SisD1P0ytfBs5Zutvk K6PajOtRc0u0Znz2n9304VfY7JM3czcbVVdtXcyyWGDuhH8Ld8xLWbSBaf8NV2OOaM76lcWt /rGrHb35X8vuCrf9l+S3MPXOtvDtnWHy2vvd3GTOKbEUZyQaajEXFScCALd6E9aSAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171212115859epcas5p1c80cacda05c36d4ef2607df2450d4aa3 X-RootMTR: 20171212115859epcas5p1c80cacda05c36d4ef2607df2450d4aa3 References: <1513079672-13652-1-git-send-email-gupta.namit@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBS6FSCT008235   Hello Steve, As per the discussion I sent patch v2. Please find. Thanks, Namit Gupta --------- Original Message --------- Sender : NAMIT GUPTA  ./Senior Chief Engineer/SRI-Delhi-Platform S/W 1 Team/Samsung Electronics Date : 2017-12-12 17:29 (GMT+5:30) Title : [PATCH v2] ftrace/module: Move ftrace_release_mod to ddebug_cleanup label   ftrace_module_init happen after dynamic_debug_setup, it is desired that cleanup should be called after this label however in current implementation it is called in free module label,ie:even though ftrace in not initialized, from so many fail case ftrace_release_mod() will be called and unnecessary traverse the whole list. In below patch we moved ftrace_release_mod() from free_module label to ddebug_cleanup label. that is the best possible location, other solution is to make new label to ftrace_release_mod() but since ftrace_module_init() is not return with minimum changes it should be in ddebug_cleanup label.     Signed-off-by: Namit Gupta    ---  kernel/module.c | 7 +------  1 file changed, 1 insertion(+), 6 deletions(-)   diff --git a/kernel/module.c b/kernel/module.c index 0d1cb8d..4be966a 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3523,6 +3523,7 @@ static int load_module(struct load_info *info, const char __user *uargs,          unset_module_core_ro_nx(mod);     ddebug_cleanup: +        ftrace_release_mod(mod);          dynamic_debug_remove(info->debug);          synchronize_sched();          kfree(mod->args); @@ -3541,12 +3542,6 @@ static int load_module(struct load_info *info, const char __user *uargs,          synchronize_rcu();          mutex_unlock(&module_mutex);   free_module: -        /* -         * Ftrace needs to clean up what it initialized. -         * This does nothing if ftrace_module_init() wasn't called, -         * but it must be called outside of module_mutex. -         */ -        ftrace_release_mod(mod);          /* Free lock-classes; relies on the preceding sync_rcu() */          lockdep_free_key_range(mod->module_core, mod->core_size);   --  1.9.1