From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753466AbdL1MeT (ORCPT ); Thu, 28 Dec 2017 07:34:19 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34604 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbdL1MeR (ORCPT ); Thu, 28 Dec 2017 07:34:17 -0500 X-Google-Smtp-Source: ACJfBovsUctmqH53335V05UbviiWEl/aNpiyliaf/3YYuUTnn+VkEwGGvyxgcAEamH15ij68dqGPTg== Date: Thu, 28 Dec 2017 13:34:14 +0100 From: Ingo Molnar To: Andy Shevchenko Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, Andi Kleen , linux-kernel@vger.kernel.org, Darren Hart , platform-driver-x86@vger.kernel.org, Bhumika Goyal , julia.lawall@lip6.fr Subject: Re: [PATCH v2] x86/platform/intel-mid: Revert "Make 'bt_sfi_data' const" Message-ID: <20171228123413.3shmkfsewmq3y4e5@gmail.com> References: <20171228122523.21802-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171228122523.21802-1-andriy.shevchenko@linux.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andy Shevchenko wrote: > v2: low the tone of accusation that this made a regression BTW., don't worry about that aspect too much: after a long debugging session it's pretty natural to be upset at whoever introduced a regression. ( In fact a number of times I too got upset at the moron who wrote a particular piece of buggy code, only for 'git annotate' to remind me that the moron was me. ) I personally just ignore the emotional attributes, and I usually edit changelogs accordingly as well so the temporary state of mind of finding a regression doesn't trickle upstream. Plus in this particular case if we can help type propagation for driver data to become a bit cleaner then the kernel project has gained a bit through all this pain. Thanks, Ingo