mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Mathieu Malaterre <malat@debian.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration
Date: Fri, 29 Dec 2017 13:49:55 +0100	[thread overview]
Message-ID: <20171229124955.w2fntu777rw4qp4v@gmail.com> (raw)
In-Reply-To: <CA+7wUszznjvTN9SAofB7BMOiXrYb_5TZhhsJ5QMAmfoTSybNUg@mail.gmail.com>


* Mathieu Malaterre <malat@debian.org> wrote:

> Hi Ingo,
> 
> On Thu, Dec 28, 2017 at 1:15 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Mathieu Malaterre <malat@debian.org> wrote:
> >
> >> Fix non-fatal warnings such as:
> >>
> >> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
> >>  static int __always_inline
> >>  ^~~~~~
> >>
> >> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> >> ---
> >>  kernel/events/ring_buffer.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Hm, never saw this warning before - is this a newly default GCC warning, or some
> > distro CFLAGS build that enables it?
> 
> Nope. Just compiling vanilla kernel with default options, defconfig
> was pmac32. I used W=1.

"W=1" is not a default build variant - it enables -Wall...

This absolutely needs to be spelled out in the changelog!

Thanks,

	Ingo

  reply	other threads:[~2017-12-29 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-26 14:09 Mathieu Malaterre
2017-12-28 12:15 ` Ingo Molnar
2017-12-28 17:23   ` Mathieu Malaterre
2017-12-29 12:49     ` Ingo Molnar [this message]
2017-12-28 12:20 ` Ingo Molnar
2017-12-28 17:25   ` Mathieu Malaterre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171229124955.w2fntu777rw4qp4v@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malat@debian.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome