From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbdL2TGB (ORCPT ); Fri, 29 Dec 2017 14:06:01 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:38421 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751200AbdL2TGA (ORCPT ); Fri, 29 Dec 2017 14:06:00 -0500 X-Google-Smtp-Source: ACJfBottpvmONEdesEX9GyVJXSY3FotsVcrhKqJK8VyMxSLSPIFNCSUllgp2fA/KjHelkiG9yQzBMg== From: Florian Fainelli To: netdev@vger.kernel.org Cc: davem@davemloft.net, Egil Hjelmeland , Florian Fainelli , Andrew Lunn , Vivien Didelot , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next] net: dsa: Fix dsa_legacy_register() return value Date: Fri, 29 Dec 2017 11:05:45 -0800 Message-Id: <20171229190545.21109-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We need to make the dsa_legacy_register() stub return 0 in order for dsa_init_module() to successfully register and continue registering the ETH_P_XDSA packet handler. Fixes: 2a93c1a3651f ("net: dsa: Allow compiling out legacy support") Reported-by: Egil Hjelmeland Signed-off-by: Florian Fainelli --- net/dsa/dsa_priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h index b03665e8fb4e..cefb0c3c6d51 100644 --- a/net/dsa/dsa_priv.h +++ b/net/dsa/dsa_priv.h @@ -103,7 +103,7 @@ void dsa_legacy_unregister(void); #else static inline int dsa_legacy_register(void) { - return -ENODEV; + return 0; } static inline void dsa_legacy_unregister(void) { } -- 2.14.1