From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750891AbdL2Wmm (ORCPT ); Fri, 29 Dec 2017 17:42:42 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:39366 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbdL2Wml (ORCPT ); Fri, 29 Dec 2017 17:42:41 -0500 From: emersion To: jpoimboe@redhat.com, linux-kernel@vger.kernel.org Cc: emersion Subject: [PATCH] objtool: fix segfault when missing parameter Date: Fri, 29 Dec 2017 23:42:22 +0100 Message-Id: <20171229224222.27159-1-contact@emersion.fr> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes a segfault when no parameter is provided to 'objtool orc'. Signed-off-by: Simon Ser --- tools/objtool/builtin-orc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/objtool/builtin-orc.c b/tools/objtool/builtin-orc.c index 4c6b5c9ef..91e8e19ff 100644 --- a/tools/objtool/builtin-orc.c +++ b/tools/objtool/builtin-orc.c @@ -44,6 +44,9 @@ int cmd_orc(int argc, const char **argv) const char *objname; argc--; argv++; + if (argc <= 0) + usage_with_options(orc_usage, check_options); + if (!strncmp(argv[0], "gen", 3)) { argc = parse_options(argc, argv, check_options, orc_usage, 0); if (argc != 1) @@ -52,7 +55,6 @@ int cmd_orc(int argc, const char **argv) objname = argv[0]; return check(objname, no_fp, no_unreachable, true); - } if (!strcmp(argv[0], "dump")) { -- 2.15.1