From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2975480-1514770274-2-1912700160225686977 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-charsets: plain='us-ascii' X-Resolved-to: linux@kroah.com X-Delivered-to: linux@kroah.com X-Mail-from: linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1514770274; b=i4kK8NIxQbQBmUHeewTnmpf+gB4M2swueT6yasg0RDpZ/I0 LYqKp+CjIhB+mBYe5+Kgr0R0VKsI9Tob/ut8cD/Jg3+9EMR0wtrkMi4xMVYogwEj VHGR2UgaTkWWhGoTXs5vau2nOGvTMq3zRppDbz1k91O9a3ITh0cNjJupEcuPPAd+ qD061zZBXytLgj6OO3IhPQVyBwL+ghi4Fcr+/WQjfgUyMgO678R8ktn3akt/7c2Z AD2QSy6lY5JznzWt6xyYcULoq8cwL7RrjL9wam2ahmn5f6mGpeVh+dWkd5Qf18lH zv5fdXOm7OW5GP1apN50q2N1rtpDyPcJGQksSUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1514770274; bh=Xhrwd+Gev0dUPM0yH4AXCaN+Xl csqMErhPE+EMjfK8o=; b=l5rpsGBn7fs0ReJNhIKLrRrPV9mJDNjh+n6aCyLc8F TelPVco1rBeDeCfFFcih6QVLFoQewhMp3PDqHhhC5dnYfztX8awOEUA4ntvJwhqt jDsJa7WIgcL8JHRlg0rEM9WSW92/oou/9nRnCAVuup8tGZ2TtZX/kp3sjHBBfIiQ GysiOuOLaSARAYPW5o3CEb2k8uzuiSRKQHF8SLqKDaVjzqvrd5eVwnTLR816E8ax 0/x0q/nYF9XsHZCx7fjEQmhiU6CBvGKrgnbyVPsrcge1AxuNBX1e8Y0tULSWHc28 +dsnKXCNhQ69F0/U9k9NWHiyjwNogTsnJUVmHdotveHA== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbeAABbI (ORCPT ); Sun, 31 Dec 2017 20:31:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:48192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbeAABbH (ORCPT ); Sun, 31 Dec 2017 20:31:07 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4884D21904 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jaegeuk@kernel.org Date: Sun, 31 Dec 2017 17:31:06 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev v2] [PATCH 1/2] f2fs: stop checkpoint only from fault injection Message-ID: <20180101013106.GB81647@jaegeuk-macbookpro.roam.corp.google.com> References: <20171229020056.60558-1-jaegeuk@kernel.org> <665883a3-f065-e531-0730-c41b227df589@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <665883a3-f065-e531-0730-c41b227df589@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX We can give another chance to write user data, which can resolve generic/441. Signed-off-by: Jaegeuk Kim --- Change log from v1: - skip stop_checkpoint for user data writes fs/f2fs/data.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index b9fab6186f28..45f65a5b9871 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -111,7 +111,8 @@ static void f2fs_write_end_io(struct bio *bio) if (unlikely(bio->bi_status)) { mapping_set_error(page->mapping, -EIO); - f2fs_stop_checkpoint(sbi, true); + if (type == F2FS_WB_CP_DATA) + f2fs_stop_checkpoint(sbi, true); } dec_page_count(sbi, type); clear_cold_data(page); -- 2.15.0.531.g2ccb3012c9-goog