From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@kernel.org>
Cc: Erick Chen <erick.chen@spreadtrum.com>,
Baolin Wang <baolin.wang@spreadtrum.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Axel Lin <axel.lin@ingics.com>
Subject: [PATCH v2] regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE
Date: Mon, 1 Jan 2018 20:38:50 +0800 [thread overview]
Message-ID: <20180101123850.21936-1-axel.lin@ingics.com> (raw)
The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes
regmap_write() call looks strange because it takes reg parameter fist
then val.
Base on Erick's suggestion to define SC2731_PWR_WR_PROT and
SC2731_WR_UNLOCK_VALUE instead.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/sc2731-regulator.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/sc2731-regulator.c b/drivers/regulator/sc2731-regulator.c
index 794fcd504b3d..eb2bdf060b7b 100644
--- a/drivers/regulator/sc2731-regulator.c
+++ b/drivers/regulator/sc2731-regulator.c
@@ -13,8 +13,8 @@
/*
* SC2731 regulator lock register
*/
-#define SC2731_PWR_WR_PROT_VALUE 0xf0c
-#define SC2731_WR_UNLOCK 0x6e7f
+#define SC2731_PWR_WR_PROT 0xf0c
+#define SC2731_WR_UNLOCK_VALUE 0x6e7f
/*
* SC2731 enable register
@@ -203,8 +203,8 @@ static struct regulator_desc regulators[] = {
static int sc2731_regulator_unlock(struct regmap *regmap)
{
- return regmap_write(regmap, SC2731_PWR_WR_PROT_VALUE,
- SC2731_WR_UNLOCK);
+ return regmap_write(regmap, SC2731_PWR_WR_PROT,
+ SC2731_WR_UNLOCK_VALUE);
}
static int sc2731_regulator_probe(struct platform_device *pdev)
--
2.14.1
next reply other threads:[~2018-01-01 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 12:38 Axel Lin [this message]
2018-01-03 6:32 ` Erick Chen
2018-01-03 12:13 ` Applied "regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180101123850.21936-1-axel.lin@ingics.com \
--to=axel.lin@ingics.com \
--cc=baolin.wang@spreadtrum.com \
--cc=broonie@kernel.org \
--cc=erick.chen@spreadtrum.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®