From: Joey Pabalinas <joeypabalinas@gmail.com>
To: x86@kernel.org
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: [PATCH] arch/x86: add __noreturn __cold to fortify_panic()
Date: Mon, 1 Jan 2018 11:36:08 -1000 [thread overview]
Message-ID: <20180101213608.3enfuk7noaui4ull@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
Definition of `fortify_panic()` doesn't match the declaration
in include/linux/string.h. Add the missing __noreturn __cold
attributes to `fortify_panic()`.
Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
---
arch/x86/boot/compressed/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
index 98761a1576ceb5c21b..707cf3f339e37f7f8c 100644
--- a/arch/x86/boot/compressed/misc.c
+++ b/arch/x86/boot/compressed/misc.c
@@ -428,7 +428,7 @@ asmlinkage __visible void *extract_kernel(void *rmode, memptr heap,
return output;
}
-void fortify_panic(const char *name)
+void __noreturn __cold fortify_panic(const char *name)
{
error("detected buffer overflow");
}
--
2.15.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2018-01-01 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 21:36 Joey Pabalinas [this message]
2018-01-01 21:41 ` Joe Perches
2018-01-01 21:46 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180101213608.3enfuk7noaui4ull@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome