From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbeACCuF (ORCPT + 1 other); Tue, 2 Jan 2018 21:50:05 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55188 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbeACCuD (ORCPT ); Tue, 2 Jan 2018 21:50:03 -0500 Date: Tue, 02 Jan 2018 21:50:02 -0500 (EST) Message-Id: <20180102.215002.671661044941618104.davem@davemloft.net> To: stephen@networkplumber.org Cc: decot@googlers.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] ethtool: do not print warning for applications using legacy API From: David Miller In-Reply-To: <20171229180252.6981-1-sthemmin@microsoft.com> References: <20171229180252.6981-1-sthemmin@microsoft.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 02 Jan 2018 18:50:03 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Stephen Hemminger Date: Fri, 29 Dec 2017 10:02:52 -0800 > From: Stephen Hemminger > > In kernel log ths message appears on every boot: > "warning: `NetworkChangeNo' uses legacy ethtool link settings API, > link modes are only partially reported" > > When ethtool link settings API changed, it started complaining about > usages of old API. Ironically, the original patch was from google but > the application using the legacy API is chrome. Chrome on my machine doesn't do this, FWIW... > Linux ABI is fixed as much as possible. The kernel must not break it > and should not complain about applications using legacy API's. > This patch just removes the warning since using legacy API's > in Linux is perfectly acceptable. > > Fixes: 3f1ac7a700d0 ("net: ethtool: add new ETHTOOL_xLINKSETTINGS API") > Signed-off-by: Stephen Hemminger Applied and queued up for -stable.